Date: Wed, 20 Oct 2021 14:35:16 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Eric Turgeon <ericbsd@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 674d093cd093 - main - x11/mate-panel: Revert "x11/mate-panel: Revert to 1.24.2 and bump PORTEPOCH" Message-ID: <20211020123516.x35p5hrbk4rofd5d@aniel.nours.eu> In-Reply-To: <202110192337.19JNbWYG049096@gitrepo.freebsd.org> References: <202110192337.19JNbWYG049096@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 19, 2021 at 11:37:32PM +0000, Eric Turgeon wrote: > The branch main has been updated by ericbsd: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=674d093cd09349d36e8dec9c0dcdf05daf0fc988 > > commit 674d093cd09349d36e8dec9c0dcdf05daf0fc988 > Author: Eric Turgeon <ericbsd@FreeBSD.org> > AuthorDate: 2021-10-19 23:34:33 +0000 > Commit: Eric Turgeon <ericbsd@FreeBSD.org> > CommitDate: 2021-10-19 23:37:24 +0000 > > x11/mate-panel: Revert "x11/mate-panel: Revert to 1.24.2 and bump PORTEPOCH" > > This reverts commit 0d45d70a5fdf13af63c2363ae7c57a1def43415f. > > It should have never been reverted at the first place. > > PR: 259058 > Reported by: John Hein I brought back portepoch it should never ever be removed. concerning the commit log, form completeness and as discuss on IRC. The revert from nc@ had a reason, there was a breakage and he considered he could not have time to fix so he reverted while this is debattable if it was done too early or not, this remain a valid reason. What was wrong was that he didn't mention at all the reasons for the revert in the commit log! Now this commit log would deserve also a bit more verbosity, you can revert back, because it seems the underlying issue was on mate-themes and the upgrade of mate-themes fixed the issue. Best regards, Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211020123516.x35p5hrbk4rofd5d>