Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Jul 2004 22:46:04 -0700 (PDT)
From:      Don Lewis <truckman@FreeBSD.org>
To:        alfred@FreeBSD.org
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c
Message-ID:  <200407150546.i6F5k4mK026902@gw.catspoiler.org>
In-Reply-To: <200407150429.i6F4Tm6U037891@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 15 Jul, Alfred Perlstein wrote:
> alfred      2004-07-15 04:29:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_shutdown.c vfs_subr.c 
>   Log:
>   Tidy up system shutdown.
>   
>   Revision  Changes    Path
>   1.156     +13 -5     src/sys/kern/kern_shutdown.c
>   1.511     +11 -1     src/sys/kern/vfs_subr.c

The message in sched_sync should refer to "vnodes remaining" since that
is what it is counting.  "Syncer syncing disks" sounds somewhat
redundant, since that is its only purpose.  Maybe "Syncer doing final
sync" would be better if verbosity is desirable.

I'd prefer skipping the the final sync() in boot() if there are no dirty
buffers, with a message something like "skipping final sync because no
dirty buffers remain".



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407150546.i6F5k4mK026902>