Date: Sun, 6 May 2018 16:58:28 -0600 From: Warner Losh <imp@bsdimp.com> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: Mark Millard <marklmi26-fbsd@yahoo.com>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys [appears to have broken the builds of head for riscv64] Message-ID: <CANCZdfpeXa6MV2ABRkuEdUi17HofKpSAeQ7rzw9UiBPtDoBzxw@mail.gmail.com> In-Reply-To: <CAG6CVpWjivydBEuur6iXdXdx7NnP7NLAtbo%2Bhjm5vpL4Da-0tg@mail.gmail.com> References: <9D64510E-32AE-45DC-87EC-4DFB41B9369F@yahoo.com> <CAG6CVpWjivydBEuur6iXdXdx7NnP7NLAtbo%2Bhjm5vpL4Da-0tg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
What we really need to do is to make bcopy a wrapper around memmove on all
architectures, not just some. It's this lack of uniformity that's causing
problems.
Warner
On Sun, May 6, 2018 at 4:32 PM, Conrad Meyer <cem@freebsd.org> wrote:
> The same change as for powerpc needs to be made for riscv =E2=80=94 the
> (bcopy) trick =E2=80=94 to avoid expansion.
>
> Best,
> Conrad
>
> P.S., Mark, your email server is misconfigured and most/all of your
> emails get flagged as spam. I only saw this because I occasionally
> check the spam folder.
>
> On Sat, May 5, 2018 at 4:39 PM, Mark Millard <marklmi26-fbsd@yahoo.com>
> wrote:
> > --- bcopy.o ---
> > In file included from /workspace/src/sys/riscv/riscv/bcopy.c:39:0:
> > /workspace/src/sys/sys/systm.h:262:31: error: expected identifier or
> '(' before '{' token
> > #define bcopy(from, to, len) ({ \
> > ^
> > /workspace/src/sys/riscv/riscv/bcopy.c:134:1: note: in expansion of
> macro 'bcopy'
> > bcopy(const void *src0, void *dst0, size_t length)
> > ^~~~~
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org=
"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpeXa6MV2ABRkuEdUi17HofKpSAeQ7rzw9UiBPtDoBzxw>