Date: Mon, 21 Aug 2006 13:37:50 -0300 From: Ricardo Nabinger Sanchez <rnsanchez@gmail.com> To: Thomas Quinot <thomas@FreeBSD.ORG> Cc: freebsd-current@freebsd.org Subject: Re: [RFC] (very) small ifmedia.c cleanup Message-ID: <20060821133750.ab3143a9.rnsanchez@gmail.com> In-Reply-To: <20060821071945.GA75839@melamine.cuivre.fr.eu.org> References: <20060821002856.601c8dfd.rnsanchez@gmail.com> <20060821071945.GA75839@melamine.cuivre.fr.eu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello,
On Mon, 21 Aug 2006 09:19:45 +0200, Thomas Quinot <thomas@FreeBSD.ORG>
wrote:
> > I was looking at src/sbin/ifconfig/ifmedia.c source, and noticed that
> > the handling of IFM_ETHER and IFM_ATM was identical. Also noticed the
> > use of goto that, IMHO, could be clearer if made with a plain if (),
> > very similar to the condition a few lines above each occurence of the
> > gotos.
>
> Looks good to me. The more factoring, the merrier! I think you could even
> push things a little further and aggressively factor what can be factored
> between print_media_word and print_media_word_ifconfig.
Thanks for your comments -- I'll surely check what can I do considering
your suggestion, and this time will fill a PR.
>
> > Now I'm wondering if this diff looks good, as it is a first one I'm
> > sending over here. The send-pr(1) seemed to be just too much noise,
> > but if that's the correct way, please let me know. The diff is against
> > -current.
>
> It never hurts to submit a PR, it helps keeping track of the discussion
> of a patch, the commit, and any possible subsequent action.
Then I'll submit a PR for this one.
Thanks again :)
--
Ricardo Nabinger Sanchez <rnsanchez@{gmail.com,wait4.org}>
Powered by FreeBSD
"Left to themselves, things tend to go from bad to worse."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060821133750.ab3143a9.rnsanchez>