Date: Wed, 7 Mar 2012 08:59:34 GMT From: John Baldwin <jhb@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 207575 for review Message-ID: <201203070859.q278xYug061696@skunkworks.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@207575?ac=10 Change 207575 by jhb@jhb_kavik on 2012/03/07 08:59:01 Now that boundaries are bus_addr_t, remove this PAE #ifdef. Affected files ... .. //depot/projects/pci/sys/dev/pci/pci.c#34 edit Differences ... ==== //depot/projects/pci/sys/dev/pci/pci.c#34 (text+ko) ==== @@ -70,17 +70,10 @@ #include "pcib_if.h" #include "pci_if.h" -/* - * XXX: Due to a limitation of the bus_dma_tag_create() API, we cannot - * specify a 4GB boundary on 32-bit targets. Usually this does not - * matter as it is ok to use a boundary of 0 on these systems. - * However, in the case of PAE, DMA addresses can cross a 4GB - * boundary, so as a workaround use a 2GB boundary. - */ -#ifdef PAE -#define PCI_DMA_BOUNDARY (1u << 31) +#if (BUS_SPACE_MAXADDR > 0xFFFFFFFF) +#define PCI_DMA_BOUNDARY 0x100000000 #else -#define PCI_DMA_BOUNDARY ((bus_size_t)((uint64_t)1 << 32)) +#define PCI_DMA_BOUNDARY 0 #endif #define PCIR_IS_BIOS(cfg, reg) \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203070859.q278xYug061696>