Date: Mon, 17 Jun 2002 14:42:42 +0200 From: Oliver Braun <obraun@informatik.unibw-muenchen.de> To: "Dr J.A.C. Stenton" <jacs@hermes.cam.ac.uk>, Lukas Ertl <l.ertl@univie.ac.at> Cc: stable@FreeBSD.ORG, brian@FreeBSD.ORG, freebsd-stable@FreeBSD.ORG Subject: Re: 4.6 kernel build problem (Symbol send_sessionid already definedng_pppoe.c) Message-ID: <20020617124242.GA94887@informatik.unibw-muenchen.de> In-Reply-To: <20020617124806.Y73368-100000@pcle2.cc.univie.ac.at> <Pine.SOL.4.44.0206171122570.7870-100000@orange.csi.cam.ac.uk> References: <20020617124806.Y73368-100000@pcle2.cc.univie.ac.at> <Pine.SOL.4.44.0206171122570.7870-100000@orange.csi.cam.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
* Dr J.A.C. Stenton <jacs@hermes.cam.ac.uk> [2002-06-17 14:23]:
> Just CVsupped the latest 4.6 code and got the following error
> on the kernel rebuild part of rebuilding the world
> ===> netgraph/pppoe
> cc -O -pipe -Wall -D_KERNEL -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@
> -I@/../include -mpreferred-stack-boundary=2 -Wall -Wredundant-decls
> -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> -Winline -Wcast-qual -fformat-extensions -ansi -c
> /usr/src/sys/modules/netgraph/pppoe/../../../netgraph/ng_pppoe.c
> /usr/src/sys/modules/netgraph/pppoe/../../../netgraph/ng_pppoe.c:860:
> redefinition of `send_sessionid'
> /usr/src/sys/modules/netgraph/pppoe/../../../netgraph/ng_pppoe.c:843:
> `send_sessionid' previously defined here
> {standard input}: Assembler messages:
> {standard input}:1531: Error: Symbol send_sessionid already defined.
> *** Error code 1
> Stop in /usr/src/sys/modules/netgraph/pppoe.
> *** Error code 1
> Stop in /usr/src/sys/modules/netgraph.
> *** Error code 1
> Stop in /usr/src/sys/modules.
> *** Error code 1
> Stop in /usr/obj/usr/src/sys/GNOME.
> *** Error code 1
> Stop in /usr/src.
> *** Error code 1
> Stop in /usr/src.
* Lukas Ertl <l.ertl@univie.ac.at> [2002-06-17 14:23]:
> Hi,
> since 4.6-RELEASE is out I'm trying to upgrade my 4-STABLE boxen to the
> latest STABLE version. The problem is that the kernel build process bombs,
> no matter if I do it with "make kernel" or with "config KERNEL && cd ...
> && make depend all". I already rm'ed the compile tree to make sure there
> are no stale object files left, but no help. I get the same error on three
> different boxes:
> ===> netgraph/pppoe
> cc -O -pipe -Wall -D_KERNEL -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@
> -I@/../include -mpreferred-stack-boundary=2 -Wall -Wredundant-decls
> -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> -Winline -Wcast-qual -fformat-extensions -ansi -c
> /usr/src/sys/modules/netgraph/pppoe/../../../netgraph/ng_pppoe.c
> /usr/src/sys/modules/netgraph/pppoe/../../../netgraph/ng_pppoe.c:860:
> redefinition of `send_sessionid'
> /usr/src/sys/modules/netgraph/pppoe/../../../netgraph/ng_pppoe.c:843:
> `send_sessionid' previously defined here
> {standard input}: Assembler messages:
> {standard input}:1531: Error: Symbol send_sessionid already defined.
> *** Error code 1
> Any ideas?
With the MFC about 10 hours ago the code for send_sessionid was included
twice[1]. Apply the attached patch to build it now or wait for a fix in
the CVS-Repository.
Regards,
Olli
1. http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netgraph/ng_pppoe.c.diff?r1=1.23.2.11&r2=1.23.2.12&f=h
--
IST & IIS _ INF _ UniBwM ___________ http://ist.unibw-muenchen.de/People/obraun/
Tele-Consulting GmbH _______________ http://www.tele-consulting.com/ ___ obraun@
FreeBSD: The Power To Serve ________ http://www.freebsd.org/ ___________________
GnuPG: 0xEF25B1BA Fingerprint: 6A3B 042A 732E 17E4 B6E7 3EAF C0B1 6B7D EF25 B1BA
[-- Attachment #2 --]
--- sys/netgraph/ng_pppoe.c.orig Mon Jun 17 14:40:44 2002
+++ sys/netgraph/ng_pppoe.c Mon Jun 17 14:41:02 2002
@@ -855,23 +855,6 @@
return (error);
}
-static int
-send_sessionid(sessp sp)
-{
- int error;
- struct ng_mesg *msg;
-
- NG_MKMESSAGE(msg, NGM_PPPOE_COOKIE, NGM_PPPOE_SESSIONID,
- sizeof(u_int16_t), M_NOWAIT);
- if (msg == NULL)
- return (ENOMEM);
-
- *(u_int16_t *)msg->data = sp->Session_ID;
- error = ng_send_msg(sp->hook->node, msg, sp->creator, NULL);
-
- return (error);
-}
-
/*
* Receive data, and do something with it.
* The caller will never free m or meta, so
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020617124242.GA94887>