Date: Tue, 26 Jun 2012 12:52:47 -0700 (PDT) From: Pedro Giffuni <pfg@freebsd.org> To: Fabian Keil <freebsd-listen@fabiankeil.de> Cc: Mark Peek <mp@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: [RFT] llquantize for FreeBSD's dtrace Message-ID: <1340740367.88309.YahooMailClassic@web113504.mail.gq1.yahoo.com> In-Reply-To: <20120626210606.632498e2@fabiankeil.de>
index | next in thread | previous in thread | raw e-mail
--- Mar 26/6/12, Fabian Keil <freebsd-listen@fabiankeil.de> ha scritto: > Pedro Giffuni <pfg@freebsd.org> wrote: > > > --- Mar 26/6/12, Mark Peek <mp@FreeBSD.org> > ha scritto: > > > > Try this, change the assert on line 1429 in file > dt_cc.c > > > from: > > > > > > assert(!(arg & (UINT16_MAX << > args[i].shift))); > > > > > > to > > > > > > assert(!(arg & ((uint64_t)UINT16_MAX << > > > args[i].shift))); > > > > > > > This certainly looks correct. Thanks Mark ! > > > > I updated the patch: > > > > http://people.freebsd.org/~pfg/patches/patch-dtrace-llquantize > > Thanks a lot. Seems to work for me: > Nice! I don't use Dtrace though ... so I'll ask: Any objections against committing it? :). Pedro.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340740367.88309.YahooMailClassic>