Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Jul 2001 11:03:30 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Kris Kennaway <kris@obsecurity.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/lib str.c
Message-ID:  <20010728110330.B11239@dragon.nuxi.com>
In-Reply-To: <20010727222750.A60313@xor.obsecurity.org>; from kris@obsecurity.org on Fri, Jul 27, 2001 at 10:27:51PM -0700
References:  <200107280444.f6S4iAu46223@freefall.freebsd.org> <20010727222750.A60313@xor.obsecurity.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 27, 2001 at 10:27:51PM -0700, Kris Kennaway wrote:
> 
> I wasn't wearing my security officer hat in requesting the backout, I
> was wearing my "Joe Ordinary Committer" hat who had his face slapped

How was I slapping your face?  You broke pkg_add on stable (MFC'ed w/o
testing).  I went in to see what changes occurred since I last fixed
`pkg_add -r' on -stable.  While looking at the changes, I saw code that
could be improved a little.  So I did.  You asked my reasoning for
cleaning up the [ex]malloc stuff last week, so in my commit email I fully
explained why the code wasn't the best. (an effort trying to make someone
asking "why" unnecessary)  And yes, I was a little derogatory to
supposed "code reduction" and "optimization" people do.  Maybe they will
consider a little more before doing them.


> by another committer who went in and rewrote some of his code without
> discussion.

Christ!  What discussion was necessary??  Did I remove or change the
purpose of your commit?

    Clean up some of the evil string handling in this code, replace
    warnx()+exit() with errx() and replace a big if..then..else construct
    to determine the package download directory with a lookup table.


> Just to be clear, we have committer guidelines which support this
> request.

So every time I see code (w/o a clear maintainer) that could be done a
little bit better, I need to make a diff, post it, have a bikeshed
discussion about it, get the permission of the one that wrote that code
originally.  Christ, you do want to make this project so bureaucratic it
is mired in molasses.  Sorry I am not going to put 3 hours of work into a
4k diff.

-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010728110330.B11239>