Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Oct 2014 02:59:55 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
Cc:        src-committers <src-committers@freebsd.org>, Ed Maste <emaste@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, "George V. Neville-Neil" <gnn@freebsd.org>, Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>, svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys
Message-ID:  <20141016225955.GE73266@FreeBSD.org>
In-Reply-To: <86wq81y9fz.fsf@nine.des.no>
References:  <201410101926.s9AJQRY1049602@svn.freebsd.org> <CA%2Bq%2BTcpt0zEbgu_LndZb4dzh=xykHvppeykuiG6P9cTJgDGeWw@mail.gmail.com> <20141015030455.GC73266@FreeBSD.org> <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com> <86wq81y9fz.fsf@nine.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 15, 2014 at 11:21:52AM +0200, Dag-Erling Smørgrav wrote:
D> Ed Maste <emaste@freebsd.org> writes:
D> > murmur3's size argument is bytes, not uint32_ts, so the test is only
D> > hashing the first 1/4 of the keys.
D> 
D> That's my fault, and I'm going to change it, because it's illogical.
D> The function works on aligned arrays of int32s and should take a count,
D> not a size.  I just didn't want to delay the patch even further.

The function should also be documented in hash(9).

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141016225955.GE73266>