Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Aug 2014 10:26:58 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r270516 - head/sys/dev/drm2/i915
Message-ID:  <2177184.NMfUXrE71G@ralph.baldwin.cx>
In-Reply-To: <201408250503.s7P53Axo057720@svn.freebsd.org>
References:  <201408250503.s7P53Axo057720@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, August 25, 2014 05:03:10 AM Adrian Chadd wrote:
> Author: adrian
> Date: Mon Aug 25 05:03:10 2014
> New Revision: 270516
> URL: http://svnweb.freebsd.org/changeset/base/270516
> 
> Log:
>   i915 driver - enable opregion handle; program CADL.
> 
>   add opregion handling for drm2 - which exposes some ACPI video
> configuration pieces that some Lenovo laptop models use to flesh out which
> video device to speak to.  This enables the brightness control in ACPI to
> work these models.
> 
>   The CADL bits are also important - it's used to figure out which ACPI
>   events to hook the brightness buttons into.  It doesn't yet seem to work
>   for me, but it does for the OP.

We should also look at enabling the opregion notification stuff.  Presumably 
that is part of ACPI-CA itself so it shouldn't be hard to make the equivalent 
calls for FreeBSD.

Also, is leaving around the #if 0'd Linux version something the drm2 code does 
in general or was that unique to this patch?  If the latter, we should remove 
the duplicate #if 0 code (list_for_each, etc.)

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2177184.NMfUXrE71G>