Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Oct 2002 14:05:26 -0700
From:      Kris Kennaway <kris@obsecurity.org>
To:        Neil Blakey-Milner <nbm@mithrandr.moria.org>
Cc:        Kris Kennaway <kris@obsecurity.org>, ports@FreeBSD.org, eivind@FreeBSD.org
Subject:   Re: Updated dialog-based config patches
Message-ID:  <20021010210526.GA28349@xor.obsecurity.org>
In-Reply-To: <20021010205723.GA20541@mithrandr.moria.org>
References:  <20020930062804.GA50001@xor.obsecurity.org> <20021006202120.GA96047@xor.obsecurity.org> <20021010132556.GA17714@mithrandr.moria.org> <20021010181035.GA19338@mithrandr.moria.org> <20021010205723.GA20541@mithrandr.moria.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--gKMricLos+KVdGMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 10, 2002 at 10:57:23PM +0200, Neil Blakey-Milner wrote:

> for option in ${OPTIONSLIST}; do
> 	eval optiontype=\$OPTION_${option}_TYPE
> 	eval optiondefault=\$OPTION_${option}_DEFAULT
> 	eval optiondescription=\$OPTION_${option}_DESCRIPTION
> 	echo "Option $option is of type $optiontype"
> 	echo "Option $option is for: $optiondescription"
> 	case $optiontype in
> 	boolean)
> 		eval withvar=\${WITH_${option}}
> 		eval withoutvar=\${WITHOUT_${option}}
> 		if [ ! -z "${withvar}" ]; then
> 			optiondefault=on
> 		elif [ ! -z "${withoutvar}" ]; then
> 			optiondefault=off
> 		fi
> 		;;
> 	esac
> 	DEFOPTIONS="${DEFOPTIONS} $option \"$optiondescription\" $optiondefault"
> done

Wouldn't this logic (which reads in existing default option values)
have to be duplicated in every replacement script?  It seems to make
more sense to do it in bsd.port.mk.

Kris

--gKMricLos+KVdGMg
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE9peuWWry0BWjoQKURAhJhAKDVnn/IN3CoYr/2D3u1YIzXltUlwgCgqgSA
ZBFNvG73FP8dZK5qa8RSnzw=
=QFWu
-----END PGP SIGNATURE-----

--gKMricLos+KVdGMg--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021010210526.GA28349>