Date: Fri, 03 Nov 2023 18:15:58 +0900 (JST) From: Yasuhiro Kimura <yasu@FreeBSD.org> To: freebsd-ports@freebsd.org Subject: Re: 'USES=shebangfix' doesn't work with samba ports Message-ID: <20231103.181558.155976036412011835.yasu@FreeBSD.org> In-Reply-To: <SI2PR01MB50368B5A6B6BC4152606803DFAA5A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com> References: <20231101.194831.884534926634764408.yasu@FreeBSD.org> <SI2PR01MB5036131DC946D79189FF0A2BFAA6A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com> <SI2PR01MB50368B5A6B6BC4152606803DFAA5A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Makino-san, From: Tatsuki Makino <tatsuki_makino@hotmail.com> Subject: Re: 'USES=shebangfix' doesn't work with samba ports Date: Fri, 3 Nov 2023 12:35:16 +0900 > Tatsuki Makino wrote on 2023/11/02 18:18: >> .include <bsd.port.options.mk> or .include <bsd.port.pre.mk> exist before this line. >> I have a feeling that is the cause :) > > Assuming we knew the reason, we needed to investigate the reason in more depth. > samba4* started shebangfix with the following commit > > https://cgit.freebsd.org/ports/commit/net/samba41/Makefile?id=e58cdfad2027226c15de6ad3508575f0dc3095c4 > > It is written in a way that creates problems at this point. > However, there would have been no problem with this, as there is no reason to leave something that does not work for almost 10 years. > So, that being the case, I checked out Mk/Uses/shebangfix.mk and here is what I found. > > https://cgit.freebsd.org/ports/commit/Mk/Uses/shebangfix.mk?id=c8de8164cad00f45461b3ca801dcad4bd56b993e > > It is possible that side effects have occurred since this time. > > There may have been some other change to Mk/bsd.port.mk being read in two passes, but I have not looked into that. > > Regards. Thanks for investigation. I have submitted the patch fixing the issue to Bugzilla. Bug 274885 net/samba413 net/samba416: Make 'USES=shebangfix' work as is expected https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274885 Regards. --- Yasuhiro Kimura
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20231103.181558.155976036412011835.yasu>