Date: Fri, 26 Mar 2004 12:35:27 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Lukas Ertl <le@FreeBSD.org> Subject: Re: Problem with g_unload_class() Message-ID: <20040326113527.GF8930@darkness.comp.waw.pl> In-Reply-To: <1621.1080299892@critter.freebsd.dk> References: <20040326110046.GD8930@darkness.comp.waw.pl> <1621.1080299892@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--zMXjX+MeVRpM4hLZ
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Mar 26, 2004 at 12:18:12PM +0100, Poul-Henning Kamp wrote:
+> But that is exactly the "silly" scenario I would like to avoid: Now
+> you have removed some of the geom instances an you have nuked the
+> taste and config function and then you give up and leave the class
+> still loaded.
BTW. Why can't we nuke config and taste here:
if (error =3D=3D 0) {
mp->taste =3D NULL;
mp->config =3D NULL;
if (mp->fini !=3D NULL)
mp->fini(mp);
LIST_REMOVE(mp, class);
}
Those events are called from the event queue, aren't they?
So this should be safe.
--=20
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
--zMXjX+MeVRpM4hLZ
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAZBV/ForvXbEpPzQRApwmAJ9OGTANOGqa1kNIy+IuvuE/50AmSACg3NTM
bhsWHc74p1aHUPgOCLqou3E=
=n0NP
-----END PGP SIGNATURE-----
--zMXjX+MeVRpM4hLZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040326113527.GF8930>