Date: Thu, 7 Dec 2017 12:04:03 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: Joe Marcus Clarke <marcus@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <20171207120403.7wafl635xclviqsr@ptrcrt.ch> In-Reply-To: <df5a59b6-df44-9a2c-2a4d-d85b15376a97@freebsd.org> References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> <df5a59b6-df44-9a2c-2a4d-d85b15376a97@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--tqowif75f5g2v4d3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Dec 7 17 06:22, Joe Marcus Clarke wrote: > On 12/7/17 03:13, Pietro Cerutti wrote: > > On Dec 7 17 08:10, Pietro Cerutti wrote: > >> On Dec 7 17 08:04, Pietro Cerutti wrote: > >>> On Aug 15 17 12:43, Joe Marcus Clarke wrote: > >>>> Author: marcus > >>>> Date: Tue Aug 15 12:43:14 2017 > >>>> New Revision: 447981 > >>>> URL: https://svnweb.freebsd.org/changeset/ports/447981 > >>>> > >>>> Log: > >>>> Update to 2.17.12. > >>> > >>>> @@ -3400,6 +3437,11 @@ sub abspathname { > >>>> =20 > >>>> if ($pre =3D~ /MASTER_SITE_SUBDIR/) { > >>>> # MASTER_SITE_SUBDIR lines are ok. > >>>> + $i =3D ''; > >>>> + } > >>>> + if ($s =3D~ /\$\{[^}]*?$i/) { > >>>> + # If we're inside a make variable, we probably do not have > >>>> + # an absolute path. > >>>> $i =3D ''; > >>>> } > >>>> } > >>>> > >>> > >>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&= 1 )=20 > >>> <-- HERE / at /usr/local/bin/portlint line 3443. > >>> > >>> I think the ? doesn't belong there. > >> > >> No, my analysis was wrong. It's about the contents of the $i variable.= =20 > >> Here's why. You can reproduce by portlint -AC in net-im/openfire. > >> > >> i is /var/log/openfire > >> WARN: Makefile: possible use of absolute pathname "/var/log/openfire". > >> > >> i is /var/db/openfire > >> WARN: Makefile: possible use of absolute pathname "/var/db/openfire". > >> > >> i is /dev/null 2>&1 ) > >> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1= )=20 > >> <-- HERE / at /usr/local/bin/portlint line 3444. > >=20 > > Surrounding $i with \Q and \E in the regex solves the problem. > >=20 > >=20 >=20 > Thanks. I'll commit a quick fix ahead of the next release. Thanks. I still don't understand why you have both * and ? as=20 quantifiers, though. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org --tqowif75f5g2v4d3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlopLi4uFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ngxTD/9Cugb4xyMyD2EY4hHrdC9v2OGwCWckMl2/SJXQnyYBqIqJpQslRYH/8f25 UN3AxIhn6ciVESqG2kDagIZckHFSBXh5neJWnngZXbydUmsGI2w1bN4a9yFbirSH XjbDd2GFiQFm2xrSFxuDEVleLgB8PMQ7LtEhyQ4B9m0Q/mAf7Fmz3F8jv1r8yccI MViB38ZlUKWrWoKLS0vSstDOD/tZYibW0Bq8VzTfyRqLbAlQnyreXaPngxzZmFYn CZxSvj5yNBOXwPelf8fxw/97o34+/+qA+0m68W8LFbk5QvA0rGt+/i8zx27nLfDN kEm/kSfS8snr+pIjAvTsF8zmOga/xxUchBaQd/GIOffKyGl1Y/o0Iq0PN1UO1q/u oYbonOVM1Yz8NaTxWuE6XBIkvWqQnjpUdKCT/PEn22DQV1EUuimMlbSNySvIWpRO xNf28n3MbBJPvh57v445dh30MO2RX/ceUUDwN5xotFdeBNZZkfH3BaqDBGQvt1x3 jPKl10wsCEvmr69+VUdhlDAiVMBmQcC91moXr6j94SMKgunOQ9rxPSt0AOb9rRn0 XukSD22KsCdtdg1zdPmPPe4pS2nl1McJs26aMSzrUM+ZiwkSgsvBBBlyMaQXtStk UB6LzmkeWHEMf70puLyKgyKhZsaPUwg56EsdyM4k16PfcvZGzg== =vW8C -----END PGP SIGNATURE----- --tqowif75f5g2v4d3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171207120403.7wafl635xclviqsr>