Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 May 2024 22:38:31 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 0dd84c3b117a - main - nvme: Add comment about where tr->deadline is set
Message-ID:  <202405132238.44DMcVoN058333@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=0dd84c3b117a01fdcac9a2f665fb156a2e358dfa

commit 0dd84c3b117a01fdcac9a2f665fb156a2e358dfa
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2024-05-13 21:58:59 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-05-13 22:14:04 +0000

    nvme: Add comment about where tr->deadline is set
    
    It's easy to overlook the chain of events that lead to tr->deadline
    being updated. Add a comment here to explain what otherwise looks like
    an oversight w/o careful study.
    
    Sponsored by:           Netflix
---
 sys/dev/nvme/nvme_qpair.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sys/dev/nvme/nvme_qpair.c b/sys/dev/nvme/nvme_qpair.c
index 4c5d5f3c1ea7..5be6c151bbea 100644
--- a/sys/dev/nvme/nvme_qpair.c
+++ b/sys/dev/nvme/nvme_qpair.c
@@ -1315,6 +1315,11 @@ _nvme_qpair_submit_request(struct nvme_qpair *qpair, struct nvme_request *req)
 		return;
 	}
 
+	/*
+	 * tr->deadline updating when nvme_payload_map calls
+	 * nvme_qpair_submit_tracker (we call it above directly
+	 * when there's no map to load).
+	 */
 	err = bus_dmamap_load_mem(tr->qpair->dma_tag_payload,
 	    tr->payload_dma_map, &req->payload, nvme_payload_map, tr, 0);
 	if (err != 0) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202405132238.44DMcVoN058333>