Date: Tue, 23 Jun 2009 17:03:20 -0400 From: John Baldwin <jhb@freebsd.org> To: Marius Strobl <marius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r194763 - in head/sys: conf dev/gem modules/gem Message-ID: <200906231703.20496.jhb@freebsd.org> In-Reply-To: <200906232036.n5NKax9O089354@svn.freebsd.org> References: <200906232036.n5NKax9O089354@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 23 June 2009 4:36:59 pm Marius Strobl wrote: > Author: marius > Date: Tue Jun 23 20:36:59 2009 > New Revision: 194763 > URL: http://svn.freebsd.org/changeset/base/194763 > > Log: > - Initialize the ifnet structure, especially if_dname, before probing > the PHYs as some PHY drivers use it (but probably shouldn't). How > gem(4) has worked with brgphy(4) on powerpc without this so far is > unclear to me. > - Introduce a dying flag which is set during detach and checked in > gem_ioctl() in order to prevent active BPF listeners to clear > promiscuous mode which may lead to the tick callout being restarted > which will trigger a panic once it's actually gone. This should not be needed assuming you follow a model of: gem_detach() { ether_ifdetach(ifp); /* calls bpfdetach() */ GEM_LOCK(sc); gem_stop(sc); GEM_UNLOCK(sc); ... } If you are invoking gem_stop() prior to ether_ifdetach() then that is your real bug. :) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906231703.20496.jhb>