Date: Tue, 12 Mar 2013 03:44:43 -0700 From: hiren panchasara <hiren.panchasara@gmail.com> To: Sergey Nasonov <snasonov@bcc.ru> Cc: Johannes Dieterich <dieterich.joh@gmail.com>, freebsd-current@freebsd.org Subject: Re: Headphone support on Thinkpad T430s Message-ID: <CALCpEUH7q0z6g63AYQXH2qstSFRXcdE%2BdJH_Kk9QtF_c5aW7LQ@mail.gmail.com> In-Reply-To: <1584949.6vl9dv5U6v@snasonovnbwxp.bcc> References: <513ED49B.4060503@gmail.com> <1584949.6vl9dv5U6v@snasonovnbwxp.bcc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 12, 2013 at 1:04 AM, Sergey Nasonov <snasonov@bcc.ru> wrote:
> I have T430 and to get headphone working I am using following workaround:
>
> hint.hdaa.4.nid21.config="as=1 seq=15" in /boot/device.hints
>
> So the final patch should looks like this
>
> Index: sys/dev/sound/pci/hda/hdaa_patches.c
> ===================================================================
> --- sys/dev/sound/pci/hda/hdaa_patches.c (revision 248186)
> +++ sys/dev/sound/pci/hda/hdaa_patches.c (working copy)
> @@ -344,7 +344,8 @@
> break;
> }
> } else if (id == HDA_CODEC_ALC269 &&
> - subid == LENOVO_X1CRBN_SUBVENDOR) {
> + (subid == LENOVO_X1CRBN_SUBVENDOR ||
> + subid == LENOVO_T430_SUBVENDOR ||
> + subid == LENOVO_T430S_SUBVENDOR)) {
> switch (nid) {
> case 21:
> patch = "as=1 seq=15";
> Index: sys/dev/sound/pci/hda/hdac.h
> ===================================================================
> --- sys/dev/sound/pci/hda/hdac.h (revision 248186)
> +++ sys/dev/sound/pci/hda/hdac.h (working copy)
> @@ -218,13 +218,14 @@
> #define LENOVO_VENDORID 0x17aa
> #define LENOVO_3KN100_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x2066)
> #define LENOVO_3KN200_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x384e)
> -#define LENOVO_B450_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x3a0d)
> +#define LENOVO_B450_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x3a0d)
> #define LENOVO_TCA55_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x1015)
> #define LENOVO_X1_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21e8)
> #define LENOVO_X1CRBN_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21f9)
> #define LENOVO_X220_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21da)
> #define LENOVO_X300_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x20ac)
> #define LENOVO_T420_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21ce)
> +#define LENOVO_T430_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21f3)
> +#define LENOVO_T430S_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21fb)
> #define LENOVO_T520_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21cf)
> #define LENOVO_ALL_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0xffff)
>
>
> On Tuesday 12 March 2013 03:09:15 Johannes Dieterich wrote:
>> Dear list,
>>
>> please see a patch to enable proper headphone support on Thinkpad T430s
>> models. The quirk uses the same logic as the recent patch to CURRENT to
>> enable some other Thinkpad models. Unfortunately, I cannot comment if
>> this will work for other models (such as the regular T430) as well,
>> therefore I used the T430S identifier.
>>
>> Hope someone can commit this,
http://svnweb.freebsd.org/changeset/base/248187
Glebius just did.
cheers,
Hiren
>>
>> Johannes
> --
> Best Regards,
> Nasonov Sergey
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALCpEUH7q0z6g63AYQXH2qstSFRXcdE%2BdJH_Kk9QtF_c5aW7LQ>