Date: Tue, 13 Feb 2018 23:13:59 -0800 From: Eitan Adler <lists@eitanadler.com> To: FreeBSD Hackers <freebsd-hackers@freebsd.org>, Warner Losh <imp@bsdimp.com>, zrj@dragonflybsd.org Subject: select call in devd Message-ID: <CAF6rxgmrkUS18kVPCK1VkBJAhBQ2vY3_MJgq%2BXNjqcx8yFi7Lw@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Hi all,
select(2) is declared with restrict for the pointers for fd. Can y'all
confirm this is the correct fix?
It is only lightly tested (it seems to do its job on my machine)
Index: devd.cc
===================================================================
--- devd.cc (revision 329192)
+++ devd.cc (working copy)
@@ -1021,7 +1021,7 @@ event_loop(void)
tv.tv_usec = 0;
FD_ZERO(&fds);
FD_SET(fd, &fds);
- rv = select(fd + 1, &fds, &fds, &fds, &tv);
+ rv = select(fd + 1, &fds, NULL, NULL, &tv);
// No events -> we've processed all pending events
if (rv == 0) {
devdlog(LOG_DEBUG, "Calling daemon\n");
--
Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmrkUS18kVPCK1VkBJAhBQ2vY3_MJgq%2BXNjqcx8yFi7Lw>