Date: Fri, 6 Jul 2001 12:00:49 +0300 From: Peter Pentchev <roam@orbitel.bg> To: arch@FreeBSD.org Cc: audit@FreeBSD.org Subject: [Fwd: Re: kern/26317: /modules not created by make installkernel] Message-ID: <20010706120049.A590@ringworld.oblivion.bg>
next in thread | raw e-mail | index | archive | help
Hi,
Anybody see how much harm can come if this patch is committed?
It does really solve a possible problem - a removed /modules dir -
by interrupting the installworld process instead of happily installing
the last module into a file named /modules.
G'luck,
Peter
--
Nostalgia ain't what it used to be.
----- Forwarded message from Gregory Bond <gnb@itga.com.au> -----
Date: Sun, 8 Apr 2001 17:10:02 -0700 (PDT)
To: freebsd-bugs@FreeBSD.org
Cc:
From: Gregory Bond <gnb@itga.com.au>
Subject: Re: kern/26317: /modules not created by make installkernel
Reply-To: Gregory Bond <gnb@itga.com.au>
The following reply was made to PR kern/26317; it has been noted by GNATS.
From: Gregory Bond <gnb@itga.com.au>
To: David Taylor <davidt@yadt.co.uk>
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: kern/26317: /modules not created by make installkernel
Date: Mon, 09 Apr 2001 10:03:24 +1000
This is a multipart MIME message.
--==_Exmh_8133331360
Content-Type: text/plain; charset=us-ascii
> It should at least bomb out with an error message, instead of pretending it
> succesfully installed your kernel and modules, even though what it
> _actually_ did was install one module as '/modules'...
A simple patch to achieve this is attached. (I.e. install into /modules/
rather than /modules to force the error to be trapped.)
--==_Exmh_8133331360
Content-Type: text/plain ; name="patch"; charset=us-ascii
Content-Description: patch
Content-Disposition: attachment; filename="patch"
Index: kmod.mk
===================================================================
RCS file: /usr/ncvs/src/sys/conf/kmod.mk,v
retrieving revision 1.82.2.5
diff -u -r1.82.2.5 kmod.mk
--- kmod.mk 2001/03/05 06:14:21 1.82.2.5
+++ kmod.mk 2001/04/08 23:59:26
@@ -217,7 +217,7 @@
realinstall: _SUBDIR
${INSTALL} ${COPY} -o ${KMODOWN} -g ${KMODGRP} -m ${KMODMODE} \
- ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}
+ ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}/
.if defined(LINKS) && !empty(LINKS)
@set ${LINKS}; \
while test $$# -ge 2; do \
--==_Exmh_8133331360--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
----- End forwarded message -----
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010706120049.A590>