Date: Tue, 23 Mar 2010 01:36:50 +0000 (UTC) From: Randall Stewart <rrs@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netinet sctp_indata.c sctputil.c sctputil.h Message-ID: <201003230137.o2N1bEDV027299@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rrs 2010-03-23 01:36:50 UTC
FreeBSD src repository
Modified files:
sys/netinet sctp_indata.c sctputil.c sctputil.h
Log:
SVN rev 205502 on 2010-03-23 01:36:50Z by rrs
Fixes a bug where SACKs in the face of
mapping_array expansion would break. Basically
once we expanded the array we no longer had both
mapping arrays in sync which the sack processing code depends on.
This would mean we were randomly referring to memory that was probably
not there. This mostly just gave us bad sack results going back to the peer.
If INVARIENTS was on of course we would hit the panic routine in the sack_check
call.
We also add a print routine for the place where one would panic in
invarients so one can see what the main mapping array holds.
Reviewed by: tuexen@freebsd.org
MFC after: 2 weeks
Revision Changes Path
1.70 +1 -35 src/sys/netinet/sctp_indata.c
1.102 +33 -14 src/sys/netinet/sctputil.c
1.39 +1 -1 src/sys/netinet/sctputil.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003230137.o2N1bEDV027299>