Date: Thu, 7 Apr 2022 10:46:15 -0600 From: Rebecca Cran <rebecca@bsdio.com> To: =?UTF-8?Q?Corvin_K=c3=b6hne?= <C.Koehne@beckhoff.com>, Peter Grehan <grehan@freebsd.org>, "devel@edk2.groups.io" <devel@edk2.groups.io> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>, FreeBSD Virtualization <freebsd-virtualization@freebsd.org>, Gerd Hoffmann <kraxel@redhat.com> Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Message-ID: <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> In-Reply-To: <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> References: <20220329101417.617-1-c.koehne@beckhoff.com> <b799a8e3f6de41eca391124ae553deec@beckhoff.com> <dc7769bd-372c-8d57-c683-ad845359b318@bsdio.com> <c6087bea-ed0e-ba94-4f58-ada1bf049ad2@freebsd.org> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I've just looked at the patch and it looks good, though I haven't tested it. So yes, please add: Acked-by: Rebecca Cran <rebecca@bsdio.com> On 4/6/22 23:24, Corvin Köhne wrote: > Hi Peter and Rebecca, > > thanks for your feedback. This patch is backward compatible. It checks > if QemuFwCfg is available and if QemuFwCfg is missing it falls > back to BhyveFwCtl. > > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > commit message? > > > Thanks > Corvin > > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8dc8c192-1bc6-71cc-d572-eda275724e99>