Date: Thu, 12 Feb 2009 17:33:44 +0100 From: Ed Schouten <ed@80386.nl> To: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: pahole - Finding holes in kernel structs Message-ID: <20090212163344.GR79178@hoeg.nl> In-Reply-To: <200902121717.47841.max@love2party.net> References: <d41814900902120608i4b54c86fp9f565bbeead5a476@mail.gmail.com> <200902121717.47841.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--3sseE1tnmEs+TkKq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Max Laier <max@love2party.net> wrote: > So to answer your first question, submitting 101 patches to rearrange 101= =20 > structs is certainly a wasted effort. However, if you take a good look a= t the=20 > 2000 holes, identify an interesting subset and submit a patch to fix that= =20 > subset ... that would be a worthwhile effort ... IMHO. I guess it's also a wasted effort to reduce struct tty from 8xx to 7xx bytes, because it still allocates 1024 bytes of memory using malloc(9). I guess we should mainly focus on structures that are allocated using uma(9) or are slightly bigger than 2^n. --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --3sseE1tnmEs+TkKq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmUT2gACgkQ52SDGA2eCwX4CgCbBWWHMVpf3rWgHyw2c2djCycj +6sAn2cXisPzxeE1GAa4/fHGjd7WuQvk =pEmH -----END PGP SIGNATURE----- --3sseE1tnmEs+TkKq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090212163344.GR79178>