Date: Thu, 20 Feb 2020 10:35:00 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: Li-Wen Hsu <lwhsu@freebsd.org>, Xin LI <d@delphij.net>, Yuri Pankov <yuripv@yuripv.me>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r358153 - head/usr.sbin/services_mkdb Message-ID: <e6011bdb-a2a8-da65-9f96-604773490192@FreeBSD.org> In-Reply-To: <CAPyFy2C=tUtZaipR5ns2SWNnST-Q0XYD9%2BCF4eqA=jgwDyRqYw@mail.gmail.com> References: <202002200354.01K3s8ib077553@repo.freebsd.org> <48DC2EEA-22D6-4A0D-84CE-3F0770962DB3@yuripv.me> <ceced76f-c742-400c-0ebc-cf13cb7e0362@delphij.net> <CAKBkRUym5NzP6CrMV1WsidYze0sMv6Um-%2B_GNtuCyCuNXM8H_w@mail.gmail.com> <CAPyFy2BcN053KiTco6dZHB2f9WTczMtM439Oyb9wd3t_bvLOLQ@mail.gmail.com> <17cf5f33-309d-5bba-dde8-bd85ce0ba191@FreeBSD.org> <CAPyFy2C=tUtZaipR5ns2SWNnST-Q0XYD9%2BCF4eqA=jgwDyRqYw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20/02/2020 10:09, Ed Maste wrote: > On Thu, 20 Feb 2020 at 09:54, Pedro Giffuni <pfg@freebsd.org> wrote: >> On 2020-02-20 09:46, Ed Maste wrote: >>> On Thu, 20 Feb 2020 at 04:56, Li-Wen Hsu <lwhsu@freebsd.org> wrote: >>>> Please note this is not fixed in ci.freebsd.org yet. The reason is it >>>> directly goes to src/release and perform `make packagesystem` to >>>> generate kernel.txz and base.txz. If I read release(7) correctly, >>>> this should be performed under a fresh installed environment. I am >>>> checking how to fix this. >>> Should we revert the change until a build fix can be committed too? >> I am OK with reverting the change, and I am rather surprised such a >> simply change could have broken the build. > Indeed, this has uncovered a broken dependency in our build process > (i.e., that the build host's services_mkdb is being used). > > IMO we should: > > 1. Revert the change for now (pfg will you take care of it?) Yes, Give me some minutes ... > 2. MFC the MAX_PROTO increase as soon as possible > 3. Try to fix the use of host's services_mkdb > 4. Recommit after either #3 is done, or FreeBSD 12.2 and 11.4 are released Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e6011bdb-a2a8-da65-9f96-604773490192>