Date: Sun, 22 Sep 2013 19:19:43 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255804 - in head/contrib/llvm/lib: CodeGen/SelectionDAG Target/AArch64 Target/ARM Target/Hexagon Target/MSP430 Target/Mips Target/NVPTX Target/PowerPC Target/R600 Target/Sparc Target/S... Message-ID: <523F891F.6010401@FreeBSD.org> In-Reply-To: <201309222203.r8MM3UjJ006580@svn.freebsd.org> References: <201309222203.r8MM3UjJ006580@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 9/22/2013 5:03 PM, Dimitry Andric wrote: > Author: dim > Date: Sun Sep 22 22:03:30 2013 > New Revision: 255804 > URL: http://svnweb.freebsd.org/changeset/base/255804 > > Log: > Pull in r191165 from upstream llvm trunk: > > ISelDAG: spot chain cycles involving MachineNodes > > Previously, the DAGISel function WalkChainUsers was spotting that it > had entered already-selected territory by whether a node was a > MachineNode (amongst other things). Since it's fairly common practice > to insert MachineNodes during ISelLowering, this was not the correct > check. > > Looking around, it seems that other nodes get their NodeId set to -1 > upon selection, so this makes sure the same thing happens to all > MachineNodes and uses that characteristic to determine whether we > should stop looking for a loop during selection. > > This should fix PR15840. 15840 is for x11-fonts/ucs-fixed. Did you put the wrong one? > > Specifically, this fixes the long-standing assertion failure when > compiling the multimedia/gstreamer port on i386. Thanks to Tijl I will update the package builder with this. Thanks! > Coosemans for his help in getting upstream to fix it. > > Approved by: re (marius) -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSP4kfAAoJEG54KsA8mwz5eyYP+gO/PQgbujnUSdx3FIK77iC9 ZuK2/Qs8Z7DrPqm2ejw5C1E/OX56cNiTQ/gQnTOdEkSK78yDJOQzxqhKSJ+63bi5 dg46onIYcUcmhOlxkHGRVv5gJlqrFHeJaByVzuwtRjTumf21ESouZsptmHwRinbv pDXNjsw2j/717vb18BPMPsq59ylFRpmz5x424iLgEivSMvJsPjutWYsKt9o0FfFL T1CLOxEHC6ZbVZI2LiKBjngdR75DWDABFmxWyfrxJToqu25T4cb3jk4SewHewByd F2PHeVlcqrZ+S+d53lZPqAnARoqFewXY89Y+YXMc7+syKE69Q9jLR5UEXXUOc0LA pS7yI33OdpwfBgBWj8n22Cg15Xzr86CQ3iNmtKwik4YYDVA2K7ygm9VgE1R0b9TF 0r0gGu6ptKVYULOGCWmmwhEm/My+b4Sp76fRP8kVruA/UFPC9FgUYwNQ6nuKGhJi m6xCsVNCAfMiO7t5rBTqjznuVK0O6/yaBRMSZ+plZQCfpQsGbjjhDrOeJcWzF5WF M0Pa45QEm3dqZ8qUrOOr3SblOC10RU+DO5a0QtQJirJuXhVeeOoZNSAqwrszIEq2 TWdKpwIxuGvwTVtsOI1U5nuJjXKga89uyv+Ib2uwkkfCCyN+SkNh4Lm9SfH+TyoS EAIZj9R/3ZkK7PV4zjDK =BMhw -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?523F891F.6010401>