Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Jul 2018 19:44:29 +0000 (UTC)
From:      Eitan Adler <eadler@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r335850 - head/usr.bin/top
Message-ID:  <201807011944.w61JiTqb076845@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eadler
Date: Sun Jul  1 19:44:29 2018
New Revision: 335850
URL: https://svnweb.freebsd.org/changeset/base/335850

Log:
  top(1): permit infinite length for command
  
  There isn't any need to limit the size of the screen. Utilities like
  'less -S' don't have a (meaningful) limit anyways.  This also makes the
  way to dynamically changing the column widths based on the screen width.

Modified:
  head/usr.bin/top/machine.c

Modified: head/usr.bin/top/machine.c
==============================================================================
--- head/usr.bin/top/machine.c	Sun Jul  1 19:44:26 2018	(r335849)
+++ head/usr.bin/top/machine.c	Sun Jul  1 19:44:29 2018	(r335850)
@@ -59,7 +59,6 @@ static const int namelength = 10;
 /* TOP_JID_LEN based on max of 999999 */
 #define TOP_JID_LEN 6
 #define TOP_SWAP_LEN 5
-static int cmdlengthdelta;
 
 /* get_process_info passes back a handle.  This is what it looks like: */
 
@@ -415,7 +414,6 @@ format_header(const char *uname_field)
 		assert("displaymode must not be set to DISP_MAX");
 	}
 
-	cmdlengthdelta = sbuf_len(header) - 7;
 	return sbuf_data(header);
 }
 
@@ -1091,10 +1089,7 @@ format_next_process(struct handle * xhandle, char *(*g
 		sbuf_printf(procbuf, "%6s ", format_time(cputime));
 		sbuf_printf(procbuf, "%6.2f%% ", ps.wcpu ? 100.0 * weighted_cpu(PCTCPU(pp), pp) : 100.0 * PCTCPU(pp));
 	}
-	sbuf_printf(procbuf, "%.*s",
-		screen_width > cmdlengthdelta ?
-		screen_width - cmdlengthdelta : 0,
-		printable(cmdbuf));
+	sbuf_printf(procbuf, "%s", printable(cmdbuf));
 	free(cmdbuf);
 	return (sbuf_data(procbuf));
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807011944.w61JiTqb076845>