Date: Thu, 14 Jan 2010 07:50:46 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: Ed Schouten <ed@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r202279 - head/lib/libc/gen Message-ID: <20100114075046.6a2ebb71@kan.dnsalias.net> In-Reply-To: <201001141000.o0EA0182095910@svn.freebsd.org> References: <201001141000.o0EA0182095910@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/yIKllgEyDeoejAqG6=xLErk Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 14 Jan 2010 10:00:01 +0000 (UTC) Ed Schouten <ed@FreeBSD.org> wrote: > Author: ed > Date: Thu Jan 14 10:00:01 2010 > New Revision: 202279 > URL: http://svn.freebsd.org/changeset/base/202279 >=20 > Log: > Revert the change to Symbol.map, made in r202274. > =20 > Even though we use __sym_compat(), we should list the symbol in > Symbol.map. > =20 > ttyslot() is now listed as follows, which seems to do the right > thing:=20 > | Symbol table '.dynsym' contains 2755 entries: > | Num: Value Size Type Bind Vis Ndx Name > | 613: 00000000000477b0 121 FUNC GLOBAL DEFAULT 10 > ttyslot@FBSD_1.0=20 > Reported by: kib >=20 > Modified: > head/lib/libc/gen/Symbol.map >=20 > Modified: head/lib/libc/gen/Symbol.map > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libc/gen/Symbol.map Thu Jan 14 09:38:23 > 2010 (r202278) +++ head/lib/libc/gen/Symbol.map Thu Jan > 14 10:00:01 2010 (r202279) @@ -272,6 +272,7 @@ FBSD_1.0 { > openlog; > closelog; > setlogmask; > + ttyslot; > ttyname_r; > ttyname; > timezone; Unnecessary, despite of what kib says. It was exported with proper version by __sym_compat already. This line in Symbol map is a NOP because there's no unadorned global 'ttyslot' symbol in the library for it to apply. Please back it out.=20 --=20 Alexander Kabaev --Sig_/yIKllgEyDeoejAqG6=xLErk Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFLTxMqQ6z1jMm+XZYRAspwAJsFVmiHBfeVhwKfDEkHHzxkqKBPigCghqJ1 cHdAktiy1OSpIB4fMHi6XEM= =mAXj -----END PGP SIGNATURE----- --Sig_/yIKllgEyDeoejAqG6=xLErk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100114075046.6a2ebb71>