Date: Sun, 02 Mar 2003 00:45:21 +0100 From: Jens Rehsack <rehsack@liwing.de> To: Barney Wolff <barney@pit.databus.com> Cc: Juli Mallett <jmallett@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: PATCH: type errors in src-tree Message-ID: <3E614611.60109@liwing.de> References: <3E5EA13E.9020208@liwing.de> <3E60F1CF.2030400@liwing.de> <20030301155546.A39174@FreeBSD.org> <3E612F7F.1090002@liwing.de> <20030301233642.GA64401@pit.databus.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Barney Wolff wrote:
> On Sat, Mar 01, 2003 at 11:09:03PM +0100, Jens Rehsack wrote:
>
> Shouldn't we care about u_char vs char? On some machines it matters,
> and on all machines compilers tend to notice and generate warnings.
Yes, usually we should. But I reviewed the code and didn't found a
reason for using 'unsigned char'. I got compiler warning ('couse I have
them enabled all) during compiling the file before I have finished the
patch. But most of the code relies on 'char' and 'u_char' was used for
storing chars only. Do you know any machine which stores signed chars
different than unsigned chars?
But the mixing - which was in it before - was not acceptable.
Jens
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E614611.60109>