Date: Wed, 20 Dec 2000 00:36:05 +0900 From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: roam@orbitel.bg Cc: msmith@FreeBSD.org, current@FreeBSD.org Subject: Re: dev/acpica/acpi.c - minor patch for cleaner poweroff Message-ID: <20001220003605D.iwasaki@jp.FreeBSD.org> In-Reply-To: <20001218165732.A5418@ringworld.oblivion.bg> References: <20001218165732.A5418@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
> I think you're the main maintainer of the ACPICA codebase (and yes, I know
> that parts of it is imported from Intel). Attached is a trivial patch which
> makes for cleaner testing for RB_POWEROFF in acpi_shutdown_final() - I've had
> various kernel/userland routines invoke reboot sequences where the howto had
> more bits set than RB_POWEROFF, e.g. RB_NOSYNC. With this patch, shutdown -p
> works for me :)
Thanks, this patch looks good. I'll fix this soon.
I'm sure mike will agree on it :-)
> Thanks for all the work on ACPICA :)
>
> G'luck,
> Peter
>
> PS. Please CC: me in replies as I'm not on -current.
>
> --
> If I had finished this sentence,
>
> Index: acpi.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v
> retrieving revision 1.7
> diff -u -r1.7 acpi.c
> --- acpi.c 2000/12/12 14:20:27 1.7
> +++ acpi.c 2000/12/18 14:55:43
> @@ -657,7 +657,7 @@
> {
> ACPI_STATUS status;
>
> - if (howto == RB_POWEROFF) {
> + if (howto & RB_POWEROFF) {
> printf("Power system off using ACPI...\n");
> if ((status = AcpiSetSystemSleepState(ACPI_STATE_S5)) != AE_OK) {
> printf("ACPI power-off failed - %s\n", acpi_strerror(status));
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001220003605D.iwasaki>