Date: Thu, 10 Jun 2004 23:40:48 -0400 From: Ken Smith <kensmith@cse.Buffalo.EDU> To: Ken Smith <kensmith@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Message-ID: <20040611034048.GE8579@electra.cse.Buffalo.EDU> In-Reply-To: <200406110334.i5B3Y2xH090581@repoman.freebsd.org> References: <200406110334.i5B3Y2xH090581@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 11, 2004 at 03:34:02AM +0000, Ken Smith wrote:
> kensmith 2004-06-11 03:34:02 UTC
>
> FreeBSD src repository
>
> Modified files:
> lib/libc/stdtime localtime.c
> Log:
> Change defualt time zone from GMT to UTC. This will not be MFC-ed, and
> was done before 5-STABLE on purpose...
>
> Revision Changes Path
> 1.38 +6 -1 src/lib/libc/stdtime/localtime.c
In my warning message sent to current@ saying this was in the works I
had asked for thoughts on whether or not to "clean up" the code,
more or less doing "s/gmt/utc/g". Those who sent in thoughts were
divided roughly half in favor, half against. I couldn't decide if
the cleanliness was worth the size of the diff so I did my usual
thing when confused about cleanliness and/or style issues - I asked
bde@. :-)
Bruce pointed out several things but the kicker was that this code
originally came from an import from a vendor branch. We import the
time zone data from that source fairly frequently. We import the
time zone code far less frequently. But a gratuitous sweep through
changing lots of variable/function names would make future code imports
unnecessarily harder. So I'll leave it as-is.
Thanks again Bruce. :-)
--
Ken Smith
- From there to here, from here to | kensmith@cse.buffalo.edu
there, funny things are everywhere. |
- Theodore Geisel |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040611034048.GE8579>