Date: Wed, 15 Nov 1995 05:54:22 -0800 From: David Greenman <davidg@Root.COM> To: Bruce Evans <bde@zeta.org.au> Cc: CVS-commiters@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c Message-ID: <199511151354.FAA00756@corbin.Root.COM> In-Reply-To: Your message of "Thu, 16 Nov 95 00:41:41 %2B1100." <199511151341.AAA05911@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
>> Modified: usr.sbin/syslogd syslogd.c >> Log: >> With the recent 'make install' change in the kernel build makefiles, an >> `interesting' feature of syslogd turned up. It calls getbootfile() for each >> log entry. Since the kernel makefile now changes kern.bootfile when doing >> a 'make install', it's quite startling to see the syslog lines change. > >I think that was a feature. The kernel name really did change. It's >interesting that getbootfile() doesn't cache the old name although >that would be easy using the static buffer. There are now two static >buffers, one of length MAXPATHLEN in getbootfile() and one of length >MAXLINE+1 in syslogd.c. MAXLINE just happens to be the same as >MAXPATHLEN. The sysctl crap in the Makefile is bogus and should be removed. My kernel is often not called "/kernel" and pretending that it was is wrong. The bootfile name should be read-only and the Makefile should not be messing with it. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511151354.FAA00756>