Date: Mon, 31 Aug 1998 08:22:40 +0200 From: Stefan Eggers <seggers@semyam.dinoco.de> To: Kris Kennaway <kkennawa@physics.adelaide.edu.au> Cc: freebsd-current@FreeBSD.ORG, seggers@semyam.dinoco.de Subject: Re: IPFW showing extra lines Message-ID: <199808310622.IAA01965@semyam.dinoco.de> In-Reply-To: Your message of "Sun, 30 Aug 1998 22:55:28 %2B0200." <199808302055.WAA02656@semyam.dinoco.de>
next in thread | previous in thread | raw e-mail | index | archive | help
>From my patch:
> valsize = len;
> if (sopt->sopt_valsize < valsize) {
> valsize = sopt->sopt_valsize;
> - sopt->sopt_valsize = len;
> }
> + sopt->sopt_valsize = len;
And here the correct fix should have been "= valsize" instead of "=
len" - otherwise the result length might end up being larger than the
buffer provided. I think then the fix is OK.
Stefan.
--
Stefan Eggers Lu4 yao2 zhi1 ma3 li4,
Max-Slevogt-Str. 1 ri4 jiu3 jian4 ren2 xin1.
51109 Koeln
Federal Republic of Germany
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808310622.IAA01965>