Date: Wed, 14 Mar 2018 07:53:33 -0700 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Ian Lepore <ian@freebsd.org>, Wojciech Macek <wma@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r330925 - in head/sys: conf powerpc/powernv Message-ID: <35bd7933-3d70-3e3f-1400-467ca6b9b561@freebsd.org> In-Reply-To: <1521037280.84937.285.camel@freebsd.org> References: <201803140920.w2E9K3mn019118@repo.freebsd.org> <1521037280.84937.285.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/14/18 07:21, Ian Lepore wrote: > On Wed, 2018-03-14 at 09:20 +0000, Wojciech Macek wrote: >> Author: wma >> Date: Wed Mar 14 09:20:03 2018 >> New Revision: 330925 >> URL: https://svnweb.freebsd.org/changeset/base/330925 >> >> Log: >> PowerNV: Fix I2C to compile if FDT is disabled >> >> Submitted by: Wojciech Macek <wma@semihalf.com> >> Obtained from: Semihalf >> Sponsored by: IBM, QCM Technologies >> > This seems to be a nonsensical commit. What's the point of compiling > in a driver which is hard-coded to return failure from the probe and > attach routines? The pre-change code seemed more correct: the driver > can only possibly work if FDT/OFW data is available, so only compile it > in when that option is in effect. > > -- Ian > It's even worse than that: the files.powerpc uses of fdt are *also* wrong, because it depends on OF, not FDT per se, which is unconditionally available on all AIM-type PowerPC kernels, so there is no need to test for *anything*. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35bd7933-3d70-3e3f-1400-467ca6b9b561>