Date: Tue, 15 Oct 2013 21:51:48 +0200 From: Markus Hitter <mah@jump-ing.de> To: sbruno@freebsd.org Cc: freebsd-embedded@freebsd.org Subject: Re: makefs(8) proposed changes [repost from fs@] Message-ID: <06526D03-28F4-4086-A82D-386A8C1AECF9@jump-ing.de> In-Reply-To: <1381853252.2682.0.camel@localhost> References: <1380730546.1619.47.camel@localhost> <1381853252.2682.0.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 15.10.2013 um 18:07 schrieb Sean Bruno:
> Index: ffs.c
> ===================================================================
> --- ffs.c (revision 255871)
> +++ ffs.c (working copy)
> @@ -470,6 +470,7 @@
> char *buf;
> int i, bufsize;
> off_t bufrem;
> + char temp_buf[16*512];
>
> assert (image != NULL);
> assert (fsopts != NULL);
> @@ -480,6 +481,7 @@
> warn("Can't open `%s' for writing", image);
> return (-1);
> }
> + read(fsopts->fd, temp_buf, 16*512);
>
> /* zero image */
> #if HAVE_STRUCT_STATVFS_F_IOSIZE && HAVE_FSTATVFS
Usually I'm only an observer here, but what's the point of reading 8
kB without using them? There's also lseek(2).
Markus
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?06526D03-28F4-4086-A82D-386A8C1AECF9>