Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 31 Oct 2013 14:00:01 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-usb@FreeBSD.org
Subject:   Re: usb/183505: commit references a PR
Message-ID:  <201310311400.r9VE010M058506@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR usb/183505; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: usb/183505: commit references a PR
Date: Thu, 31 Oct 2013 13:54:59 +0000 (UTC)

 Author: adrian
 Date: Thu Oct 31 13:54:51 2013
 New Revision: 257446
 URL: http://svnweb.freebsd.org/changeset/base/257446
 
 Log:
   Allow the Arduino Leonardo to work by supporting CDC=0 devices.
   
   CDC=0 simply means "no command codes", CDC=1 means "AT command codes."
   There's no driver change required!  It's purely to tell the application
   layer whether to speak AT commands or not.  Things are all still serial.
   
   PR:		usb/183505
   Reviewed by:	hps
   MFC after:	1 week
 
 Modified:
   head/sys/dev/usb/serial/umodem.c
   head/sys/dev/usb/usb.h
 
 Modified: head/sys/dev/usb/serial/umodem.c
 ==============================================================================
 --- head/sys/dev/usb/serial/umodem.c	Thu Oct 31 13:47:39 2013	(r257445)
 +++ head/sys/dev/usb/serial/umodem.c	Thu Oct 31 13:54:51 2013	(r257446)
 @@ -128,6 +128,9 @@ static const STRUCT_USB_HOST_ID umodem_d
  	{USB_IFACE_CLASS(UICLASS_CDC),
  		USB_IFACE_SUBCLASS(UISUBCLASS_ABSTRACT_CONTROL_MODEL),
  		USB_IFACE_PROTOCOL(UIPROTO_CDC_AT)},
 +	{USB_IFACE_CLASS(UICLASS_CDC),
 +		USB_IFACE_SUBCLASS(UISUBCLASS_ABSTRACT_CONTROL_MODEL),
 +		USB_IFACE_PROTOCOL(UIPROTO_CDC_NONE)},
  	/* Huawei Modem class match */
  	{USB_IFACE_CLASS(UICLASS_CDC),
  		USB_IFACE_SUBCLASS(UISUBCLASS_ABSTRACT_CONTROL_MODEL),
 
 Modified: head/sys/dev/usb/usb.h
 ==============================================================================
 --- head/sys/dev/usb/usb.h	Thu Oct 31 13:47:39 2013	(r257445)
 +++ head/sys/dev/usb/usb.h	Thu Oct 31 13:54:51 2013	(r257446)
 @@ -441,6 +441,7 @@ typedef struct usb_interface_assoc_descr
  #define	UISUBCLASS_ETHERNET_EMULATION_MODEL 12
  #define	UISUBCLASS_NETWORK_CONTROL_MODEL 13
  
 +#define	UIPROTO_CDC_NONE		0
  #define	UIPROTO_CDC_AT			1
  
  #define	UICLASS_HID		0x03
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310311400.r9VE010M058506>