Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Jan 2016 02:20:15 +0000 (UTC)
From:      Justin Hibbits <jhibbits@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r293129 - head/sys/powerpc/booke
Message-ID:  <201601040220.u042KF56042108@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhibbits
Date: Mon Jan  4 02:20:14 2016
New Revision: 293129
URL: https://svnweb.freebsd.org/changeset/base/293129

Log:
  Make arguments for booke_init() u_long, to match register width.
  
  On powerpc64, pointers are 64 bits, so casting from uint32_t changes the integer
  width.
  
  The alternative was to use register_t, but I didn't see register_t used as
  argument type for any other functions, though didn't look too closely.  u_long
  was an acceptable alternative.  On 64-bit it's 64 bits, on 32-bit it's 32 bits.

Modified:
  head/sys/powerpc/booke/booke_machdep.c

Modified: head/sys/powerpc/booke/booke_machdep.c
==============================================================================
--- head/sys/powerpc/booke/booke_machdep.c	Mon Jan  4 01:33:07 2016	(r293128)
+++ head/sys/powerpc/booke/booke_machdep.c	Mon Jan  4 02:20:14 2016	(r293129)
@@ -173,7 +173,7 @@ uint32_t *bootinfo;
 
 void print_kernel_section_addr(void);
 void print_kenv(void);
-uintptr_t booke_init(uint32_t, uint32_t);
+uintptr_t booke_init(u_long, u_long);
 void ivor_setup(void);
 
 extern void *interrupt_vector_base;
@@ -268,7 +268,7 @@ booke_check_for_fdt(uint32_t arg1, vm_of
 }
 
 uintptr_t
-booke_init(uint32_t arg1, uint32_t arg2)
+booke_init(u_long arg1, u_long arg2)
 {
 	uintptr_t ret;
 	void *mdp;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201601040220.u042KF56042108>