Date: Fri, 15 Jul 2016 16:22:19 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: Baptiste Daroussin <bapt@FreeBSD.org> Subject: Re: svn commit: r302324 - head/lib/libc/locale Message-ID: <677f087c-1270-8435-83c7-a240ed2599b2@FreeBSD.org> In-Reply-To: <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> References: <201607031500.u63F0Cr8099783@repo.freebsd.org> <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15/07/2016 4:19 PM, Jung-uk Kim wrote: > On 07/03/16 11:00 AM, Baptiste Daroussin wrote: >> Author: bapt >> Date: Sun Jul 3 15:00:12 2016 >> New Revision: 302324 >> URL: https://svnweb.freebsd.org/changeset/base/302324 >> >> Log: >> Fix a bad test resulting in a segfault with ISO-8859-5 locales >> >> Reported by: Lauri Tirkkonen from Illumos >> Approved by: re@ (gjb) >> >> Modified: >> head/lib/libc/locale/collate.c >> >> Modified: head/lib/libc/locale/collate.c >> ============================================================================== >> --- head/lib/libc/locale/collate.c Sun Jul 3 11:45:54 2016 (r302323) >> +++ head/lib/libc/locale/collate.c Sun Jul 3 15:00:12 2016 (r302324) >> @@ -310,7 +310,7 @@ _collate_lookup(struct xlocale_collate * >> if ((sptr = *state) != NULL) { >> *pri = *sptr; >> sptr++; >> - if ((sptr == *state) || (sptr == NULL)) >> + if ((sptr == *state) || (*sptr == 0)) >> *state = NULL; >> else >> *state = sptr; > > I had a serious regression with ko_KR.UTF-8 locale after this commit. > MATE is unusable because mate-panel is busy looping and eating 100% CPU. > GNOME 3 does not start at all, i.e., nothing but mouse cursor on black > screen. After reverting this commit, everything is back to normal. > Please investigate. IMHO, this must be fixed before 11.0-BETA2 build. > > Thanks, > > Jung-uk Kim > Please report a bug so it can be tracked and not forgotten: Add re@ and original committer to cc Set mfc-stable11 to ? Add keyword: regression
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?677f087c-1270-8435-83c7-a240ed2599b2>