Date: Thu, 28 Sep 2006 14:20:53 -0400 From: John Baldwin <jhb@freebsd.org> To: Ruslan Ermilov <ru@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/dev/vkbd vkbd.c src/sys/fs/procfs procfs_ioctl.c ... Message-ID: <200609281420.54038.jhb@freebsd.org> In-Reply-To: <20060928162143.GA59634@rambler-co.ru> References: <200609271957.k8RJv25Z028902@repoman.freebsd.org> <200609281056.28105.jhb@freebsd.org> <20060928162143.GA59634@rambler-co.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 28 September 2006 12:21, Ruslan Ermilov wrote: > > Are there any others outside of SES? How many? If it's a small list, then > > let's fix them. The SES ones are broken as an API anyway as mentioned above, > > and if other ioctl's are copying out a variable amount of data w/o allowing > > for buffer lengths or telling userland how much it copied, they are also > > fundamentally broken as well. > > > Some only read from userland, so they aren't broken. I'll compile and send > you the list of such ioctls (don't have it saved)... Ah, here's one from > memory that isn't broken: SPKRTUNE from sys/dev/speaker/. Scott pointed out one in aac(4) that is required for a binary-only management tool, so it looks like we are stuck _IO being used with pointers. :( -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200609281420.54038.jhb>