Date: Sat, 19 Nov 2011 00:35:04 +0100 From: Marius Strobl <marius@alchemy.franken.de> To: Ben Hutchings <bhutchings@solarflare.com> Cc: freebsd-net@freebsd.org, Philip Paeps <philip@freebsd.org> Subject: Re: sfxge: Remove interrupt self-test code Message-ID: <20111118233504.GK93221@alchemy.franken.de> In-Reply-To: <1321652051.2883.76.camel@bwh-desktop> References: <1321652051.2883.76.camel@bwh-desktop>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 18, 2011 at 09:34:11PM +0000, Ben Hutchings wrote: > sfxge: Remove interrupt self-test code > > It's not currently used; it didn't build on 32-bit and the previous > build fix is incorrect. If we really implement self-tests we can do > this again properly. Yes, I've also already noticed that this part of r227640 wasn't quite correct. However Philip suggested to just leave it in for now until we figure out what on earth the code actually is supposed to do and as the atomic_cmpset_ptr(9) also works on LP64 and isn't more broken than the atomic_cmpset_long(9) that was in there before (actually this should have been atomic_cmpset_64(9) for an uint64_t, which isn't necessarily available on ILP32 including i386 though). Probably this should have been converted to be of type cpuset_t and to use the accessors from <sys/cpuset.h> as nowadays we also support more than 64 CPUs. I'm also fine with just nuking the interrupt self-test altogether though. Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111118233504.GK93221>