Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Apr 2019 19:19:51 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r345778 - in head/gnu/usr.bin/gdb: gdb kgdb
Message-ID:  <201904011919.x31JJpOv000579@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Mon Apr  1 19:19:51 2019
New Revision: 345778
URL: https://svnweb.freebsd.org/changeset/base/345778

Log:
  Fix gdb/kgdb build under WITH_PIE
  
  Explicitly specified bare .a libraries need ${PIE_SUFFIX}.
  
  Reported by:	David E. Cross, on twitter
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/gnu/usr.bin/gdb/gdb/Makefile
  head/gnu/usr.bin/gdb/kgdb/Makefile

Modified: head/gnu/usr.bin/gdb/gdb/Makefile
==============================================================================
--- head/gnu/usr.bin/gdb/gdb/Makefile	Mon Apr  1 19:08:05 2019	(r345777)
+++ head/gnu/usr.bin/gdb/gdb/Makefile	Mon Apr  1 19:19:51 2019	(r345778)
@@ -3,9 +3,10 @@
 PROG=	gdb${GDB_SUFFIX}
 SRCS=	gdb.c
 
-BULIBS= ${OBJ_BU}/libbfd/libbfd.a ${OBJ_BU}/libopcodes/libopcodes.a \
-	${OBJ_BU}/libiberty/libiberty.a
-GDBLIBS= ${OBJ_GDB}/libgdb/libgdb.a
+BULIBS= ${OBJ_BU}/libbfd/libbfd${PIE_SUFFIX}.a \
+	${OBJ_BU}/libopcodes/libopcodes${PIE_SUFFIX}.a \
+	${OBJ_BU}/libiberty/libiberty${PIE_SUFFIX}.a
+GDBLIBS= ${OBJ_GDB}/libgdb/libgdb${PIE_SUFFIX}.a
 
 # libthread_db.so calls back into gdb for the proc services.  Make all the
 # global symbols visible.

Modified: head/gnu/usr.bin/gdb/kgdb/Makefile
==============================================================================
--- head/gnu/usr.bin/gdb/kgdb/Makefile	Mon Apr  1 19:08:05 2019	(r345777)
+++ head/gnu/usr.bin/gdb/kgdb/Makefile	Mon Apr  1 19:19:51 2019	(r345778)
@@ -4,9 +4,10 @@ PROG=	kgdb${GDB_SUFFIX}
 SRCS=	main.c kld.c kthr.c trgt.c trgt_${TARGET_CPUARCH}.c
 WARNS?=	2
 
-BULIBS= ${OBJ_BU}/libbfd/libbfd.a ${OBJ_BU}/libopcodes/libopcodes.a \
-	${OBJ_BU}/libiberty/libiberty.a
-GDBLIBS= ${OBJ_GDB}/libgdb/libgdb.a
+BULIBS= ${OBJ_BU}/libbfd/libbfd${PIE_SUFFIX}.a \
+	${OBJ_BU}/libopcodes/libopcodes${PIE_SUFFIX}.a \
+	${OBJ_BU}/libiberty/libiberty${PIE_SUFFIX}.a
+GDBLIBS= ${OBJ_GDB}/libgdb/libgdb${PIE_SUFFIX}.a
 
 DPADD=	${GDBLIBS} ${BULIBS}
 LDADD=	${GDBLIBS} ${BULIBS}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904011919.x31JJpOv000579>