Date: Fri, 2 Aug 2013 16:39:12 +0200 From: Attilio Rao <attilio@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253877 - in projects/atomic64/sys: amd64/include i386/include Message-ID: <CAJ-FndATMK8hfgFY-mmkzL1ftjZN-Jxx6CFRs7J18M4=0oMVZw@mail.gmail.com> In-Reply-To: <201308020020.r720K5Gu099845@svn.freebsd.org> References: <201308020020.r720K5Gu099845@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 2, 2013 at 2:20 AM, Jung-uk Kim <jkim@freebsd.org> wrote: > Author: jkim > Date: Fri Aug 2 00:20:04 2013 > New Revision: 253877 > URL: http://svnweb.freebsd.org/changeset/base/253877 > > Log: > Reimplement atomic operations on PDEs and PTEs in pmap.h. This change > significantly reduces duplicate code. Also, it may improve and even correct > some questionable implementations. I think this is not the right way to do it, in particular the loadstore part. What you should do is to implement atomic_readandclear_* with an atomic_readandset_* (so taking a parameter as a set value) and then use atomic_readandset_*() for PTE operations. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndATMK8hfgFY-mmkzL1ftjZN-Jxx6CFRs7J18M4=0oMVZw>