Date: Wed, 10 Dec 2003 02:30:20 -0800 (PST) From: Lukas Ertl <l.ertl@univie.ac.at> To: freebsd-doc@FreeBSD.org Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook Message-ID: <200312101030.hBAAUKDb001996@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/60107; it has been noted by GNATS. From: Lukas Ertl <l.ertl@univie.ac.at> To: j.el-rayes@daemon.li Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook Date: Wed, 10 Dec 2003 11:21:44 +0100 (CET) On Wed, 10 Dec 2003, Josef El-Rayes wrote: > Lukas Ertl <l.ertl@univie.ac.at> wrote: > > +#include <sys/param.h> /* defines used in kernel.h */ > > -#include <sys/param.h> /* defines used in kernel.h */ > > hi lukas! > > it is a good idea to have a look at the diff-generated patch > before sending in, to avoid bogus lines like this. It is a good idea to actually understand what the patch does before calling it bogus. The original code had sys/param.h and sys/types.h included, which is a style(9) violation. My patch removes one include and moves the other one further up. regards, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312101030.hBAAUKDb001996>