Date: Thu, 26 Sep 2019 14:11:47 -0300 From: Renato Botelho <garga@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338888 - head/sbin/devd Message-ID: <a77ad159-f160-dc1d-1253-6779c389d9b3@FreeBSD.org> In-Reply-To: <201809221532.w8MFWsPk073665@repo.freebsd.org> References: <201809221532.w8MFWsPk073665@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22/09/18 12:32, Warner Losh wrote: > Author: imp > Date: Sat Sep 22 15:32:53 2018 > New Revision: 338888 > URL: https://svnweb.freebsd.org/changeset/base/338888 > > Log: > We don't need shell protection for when we're expanding matches. > Don't add it. This should fix when we do regepx matches against > variables we've set and fix wifi bring up. > > PR: 231441 > Approved by: re@ (kib) > Differential Revision: https://reviews.freebsd.org/D17267 Warner, We are seeing unexpected $ on /var/log/messages when matches are replaced inside shell commands between single quotes. With action set as follow: action "logger -t kern.notice 'device-name=$device-name start'"; We see a log entry like this: Sep 26 13:56:06 x230 kern.notice[27604]: device-name=$rtwn0 start Reverting this change made it to log properly: Sep 26 13:56:06 x230 kern.notice[27604]: device-name=rtwn0 start There is an open bug already: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240411 -- Renato Botelho
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a77ad159-f160-dc1d-1253-6779c389d9b3>