Date: Sun, 28 Dec 2014 11:01:30 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: Kubilay Kocak <koobs@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r375696 - head/multimedia/libx264 Message-ID: <alpine.LSU.2.11.1412281100080.3428@tuna.site> In-Reply-To: <201412280459.sBS4xbU9021196@svn.freebsd.org> References: <201412280459.sBS4xbU9021196@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 2014-12-28 04:59, Kubilay Kocak wrote:
> Log:
> multimedia/libx264: Fix PGO/GCC options
>
> - Revert options helpers for PGO and GCC .. *shakes fist*. We end up
> setting USE_GCC=yes yes otherwise, and that's not valid.
> - libx264 and x264 share the same distfiles, use the same DIST_SUBDIR
> +.if ${PORT_OPTIONS:MGCC}
> +USE_GCC= yes
> +.elif ${PORT_OPTIONS:MPGO}
> +USE_GCC= any
> +.endif
Why not USE_GCC=yes in either case?
Using anything like the old version of GCC in base (GCC 4.2) for
anyone asking for PGO feels just, hmm, odd. Plus it complicates
the testing matrix.
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.11.1412281100080.3428>