Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Oct 2023 18:01:09 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 4efaf43c6fa7 - main - ping: Require root user for pytests
Message-ID:  <202310111801.39BI19jf053946@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=4efaf43c6fa76e0daa1ed5ea535d863f15415bf4

commit 4efaf43c6fa76e0daa1ed5ea535d863f15415bf4
Author:     Jose Luis Duran <jlduran@gmail.com>
AuthorDate: 2023-10-11 13:57:11 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2023-10-11 17:48:28 +0000

    ping: Require root user for pytests
    
    atf_python may use vnet jails for creating an isolated test environment.
    Mark these tests that require root user privileges.
    
    Reviewed by:    markj
    MFC after:      1 week
    Pull Request:   https://github.com/freebsd/freebsd-src/pull/863
---
 sbin/ping/tests/test_ping.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sbin/ping/tests/test_ping.py b/sbin/ping/tests/test_ping.py
index 645940a62cb6..900fbf45d52d 100644
--- a/sbin/ping/tests/test_ping.py
+++ b/sbin/ping/tests/test_ping.py
@@ -723,6 +723,7 @@ PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2
     ]
 
     @pytest.mark.parametrize("expected", testdata)
+    @pytest.mark.require_user("root")
     def test_ping(self, expected):
         """Test ping"""
         ping = subprocess.run(
@@ -751,6 +752,7 @@ PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2
     ]
 
     @pytest.mark.parametrize("expected", ping46_testdata)
+    @pytest.mark.require_user("root")
     def test_ping_46(self, expected):
         """Test ping -4/ping -6"""
         for version in [4, 6]:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202310111801.39BI19jf053946>