Date: Wed, 11 Sep 2024 16:45:28 +0300 From: Matthias Fechner <mfechner@freebsd.org> To: "Jason E. Hale" <jhale@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a53a752a3565 - main - www/rubygem-json-jwt115: Remove expired port Message-ID: <324316d3-8167-42a3-a2ed-06546defd6a2@freebsd.org> In-Reply-To: <CAJE75NFscbBAru8NCp_r_fZA6crfHuhV-fQ60q37tjCCZME2=g@mail.gmail.com> References: <202409110621.48B6LPQZ065287@gitrepo.freebsd.org> <ZuE3rYnGEbHRsG-h@FreeBSD.org> <CAJE75NFscbBAru8NCp_r_fZA6crfHuhV-fQ60q37tjCCZME2=g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 11.09.2024 um 14:25 schrieb Jason E. Hale: > On Wed, Sep 11, 2024 at 2:24 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: >> On Wed, Sep 11, 2024 at 06:21:25AM +0000, Matthias Fechner wrote: >>> commit a53a752a35654ecd756ca11c46c0d56944bb0cfc >>> >>> www/rubygem-json-jwt115: Remove expired port >>> >>> www/rubygem-json-jwt115 >> I keep seeing this silly useless extra line with nothing else but the >> portname added to the commit log, what's the purpose of it? If this >> is due to some broken port removal script, can someone please fix it? >> >> ./danfe > This is definitely from Tools/scripts/rmport, which seems to be more > focused on the bulk removal of expired ports rather than on the > removal of individual non-expired ports for other reasons. This port, > for example, didn't have EXPIRATION_DATE set, but the generated commit > message suggests that it was expired, which is a problem in and of > itself. The rmport script just assumes the port is expired and doesn't > do any checks to verify whether that is actually the case for the main > commit message. The generated MOVED entry is slightly more bespoke, > which leads me to believe that the MOVED entry in this case was > manually edited. I don't use rmport for individual ports (or really > ever because it requires me to edit it to even use it due to my git > remotes settings not matching up to what it expects, but if these > extra lines in commit messages bother you that much, here's your > starting point to make the change you want to see. It would be wise to > consult with our esteemed Grim Reaper (rene@) before committing any > changes, though. > > - Jason thanks for the summary. Yes I use the rmport script as it does some additional checks (including requests to bugzilla) and some stupid work which is very convenient. And I just edit the MOVED file to put in there the required information. If the commit message is bad, the rmport script should be adapted. I call the script e.g. with: ~/bin/rmport www/rubygem-json-jwt115 If that happens, maybe there can also be the fixed path `/usr/ports` be removed, as I host my repository in my home dir and that is the reason why I copied version to ~/bin and modified it to point to my directory on my home dir. So if you have something to test, please let me know. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?324316d3-8167-42a3-a2ed-06546defd6a2>