Date: Fri, 3 Nov 2017 16:04:23 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325116 - head Message-ID: <a5f57322-3dfe-0cd2-0366-0eea064327cb@FreeBSD.org> In-Reply-To: <CANCZdfr6s0wWs%2BjYCVjAVEj0c_=5PGGz%2BnU-u8O61snNQjPKkQ@mail.gmail.com> References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <CANCZdfpXuLkS843%2BjneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2%2BLg@mail.gmail.com> <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> <CANCZdfr6s0wWs%2BjYCVjAVEj0c_=5PGGz%2BnU-u8O61snNQjPKkQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eA8s7LR5c9A9FMgd2d807p7aox4ugBLJG Content-Type: multipart/mixed; boundary="caENqGobbUAEm2AOSdoFb3X1Wq6DVF8gW"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <a5f57322-3dfe-0cd2-0366-0eea064327cb@FreeBSD.org> Subject: Re: svn commit: r325116 - head References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <CANCZdfpXuLkS843+jneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2+Lg@mail.gmail.com> <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> <CANCZdfr6s0wWs+jYCVjAVEj0c_=5PGGz+nU-u8O61snNQjPKkQ@mail.gmail.com> In-Reply-To: <CANCZdfr6s0wWs+jYCVjAVEj0c_=5PGGz+nU-u8O61snNQjPKkQ@mail.gmail.com> --caENqGobbUAEm2AOSdoFb3X1Wq6DVF8gW Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/3/2017 3:45 PM, Warner Losh wrote: >=20 >=20 > On Fri, Nov 3, 2017 at 4:40 PM, Bryan Drewery <bdrewery@freebsd.org > <mailto:bdrewery@freebsd.org>> wrote: >=20 > On 11/3/2017 3:32 PM, Warner Losh wrote: > > > > > > On Fri, Nov 3, 2017 at 4:28 PM, Bryan Drewery <bdrewery@freebsd.o= rg <mailto:bdrewery@freebsd.org> > > <mailto:bdrewery@freebsd.org <mailto:bdrewery@freebsd.org>>> wrot= e: > > > >=C2=A0 =C2=A0 =C2=A0On 10/29/2017 8:12 PM, Warner Losh wrote: > >=C2=A0 =C2=A0 =C2=A0> Author: imp > >=C2=A0 =C2=A0 =C2=A0> Date: Mon Oct 30 03:12:38 2017 > >=C2=A0 =C2=A0 =C2=A0> New Revision: 325116 > >=C2=A0 =C2=A0 =C2=A0> URL: https://svnweb.freebsd.org/changeset/ba= se/325116 > <https://svnweb.freebsd.org/changeset/base/325116>; > >=C2=A0 =C2=A0 =C2=A0<https://svnweb.freebsd.org/changeset/base/325= 116 > <https://svnweb.freebsd.org/changeset/base/325116>>; > >=C2=A0 =C2=A0 =C2=A0> > >=C2=A0 =C2=A0 =C2=A0> Log: > >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0Return proper status from builde= nv. > >=C2=A0 =C2=A0 =C2=A0> > >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0make buildenv BUILDENV_SHELL=3D<= some command> more useful. > Remove '|| > >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0true' from the command line so t= hat errors are properly > >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0returned. There appears to be no= reason for it, and it > dates back to > >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0the original commit by ru@. > >=C2=A0 =C2=A0 =C2=A0> > >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0Sponsored by: Netflix > > > >=C2=A0 =C2=A0 =C2=A0Now simply running 'make buildenv' and 'exit' = throws a make error. > > > >=C2=A0 =C2=A0 =C2=A0Perhaps we need a BUILDENV_CMDS that does what= you want and we > otherwise > >=C2=A0 =C2=A0 =C2=A0leave the ${BUILDENV_SHELL} || true handling. > > > > > > Are you sure? > > > > 4:29pm zooty:[242]> make buildenv > > Entering world for amd64:amd64 > > $ exit > > 4:29pm zooty:[243]> > > > > Perhaps you can give me an example that causes that? This was the= very > > first thing I checked before committing the fix... > > >=20 > Only happens with zsh. >=20 > > [root@c1100-1][pts/8][zsh/2][Fri 11/03/2017 15:40:10 PDT][0?2&] > (git-svn)-[master]- > > ~/git/freebsd # BUILDENV_SHELL=3Dcsh make buildenv > > Entering world for amd64:amd64 > > root@c1100-1:~/git/freebsd # exit > > exit > > ~/git/freebsd # BUILDENV_SHELL=3D/usr/local/bin/zsh make buildenv= > > Entering world for amd64:amd64 > > For ZSH you must run: export CPUTYPE=3D > > (buildenv) [root@c1100-1][pts/8][zsh/3][Fri 11/03/2017 15:40:23 > PDT][1?0&] (git-svn)-[master]- The 1? above means the last command returned 1. Hmm, I wonder why. > > ~/git/freebsd # exit > > *** Error code 1 > > > > Stop. > > make[1]: stopped in /root/git/freebsd > > *** Error code 1 > > > > Stop. > > make: stopped in /root/git/freebsd >=20 >=20 > Shouldn't this be fixed in upstream zsh rather than yet another ZSH war= t > in the buildsystem that literally has another ZSH wart in the same line= ? >=20 > Warner --=20 Regards, Bryan Drewery --caENqGobbUAEm2AOSdoFb3X1Wq6DVF8gW-- --eA8s7LR5c9A9FMgd2d807p7aox4ugBLJG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/PX3AAoJEDXXcbtuRpfPjQUH/3vFpQZHjfToyl1KGQaw/acz J+5oQxoqownrEo1/dQnhUNmTsA1xqZ3LYHqSCOMlP6qI7/omVjlbTE62D7H1Ig0a vbO9WnPUmgvRCN6X91L79S10JDBivC56VZIIIZbTGvGKIDWn6q7DWQZdi8riJPtU z1kFiyQuhLSP7cJYHCB5gxv6uiJUM68bTp+kI780HC/cWgXMjsTL/h14Vt2IHdgv IsHfPttVAPptgegw+2iVZGOCLso2mUcK+9+9UAijC51cG93+RYclkxmjFoNvU5dP qjr07Ua2fKKs3kcNeD6t4r/rS+qOltFAj7V08/MtalMYkR3dfIbNOShNXzDFyWo= =mWmd -----END PGP SIGNATURE----- --eA8s7LR5c9A9FMgd2d807p7aox4ugBLJG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a5f57322-3dfe-0cd2-0366-0eea064327cb>