Date: Sun, 12 Feb 2023 15:06:24 -0700 From: Warner Losh <imp@bsdimp.com> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Jessica Clarke <jrtc27@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: eca005d8531f - main - zlib: silence K&R warns Message-ID: <CANCZdfrHwRfuoCJrUAjQrvMyXduZ_qbWhBqz6cZeNi7KRpWjaA@mail.gmail.com> In-Reply-To: <CAGudoHGyU10_GRc%2BBEYjR43KqwC4gxk9jme8=1quuNHAUFxgsA@mail.gmail.com> References: <202302122113.31CLD2av012258@gitrepo.freebsd.org> <72B4A01A-521D-4739-B1DD-6A19E98771EE@freebsd.org> <CAGudoHH-m%2BA1J9yr2gi3D=9ef3Nt2iQh60VCUf9%2BFDQfk%2Bf8sg@mail.gmail.com> <05AA573A-9692-40C3-8BF6-D52864BAB337@freebsd.org> <CAGudoHHPh04DXTp-PZC8v_dpj%2BpkMf7gzk=9jUXKOzbvQ_Wa3Q@mail.gmail.com> <CANCZdfrpn0OO8J_ci79Ogo2Y0jN05=eeCax6PCBnAuAQJvDdsw@mail.gmail.com> <CAGudoHGyU10_GRc%2BBEYjR43KqwC4gxk9jme8=1quuNHAUFxgsA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000a947c605f487f118 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 2:54 PM Mateusz Guzik <mjguzik@gmail.com> wrote: > On 2/12/23, Warner Losh <imp@bsdimp.com> wrote: > > On Sun, Feb 12, 2023 at 2:40 PM Mateusz Guzik <mjguzik@gmail.com> wrote= : > > > >> On 2/12/23, Jessica Clarke <jrtc27@freebsd.org> wrote: > >> > On 12 Feb 2023, at 21:23, Mateusz Guzik <mjguzik@gmail.com> wrote: > >> >> > >> >> On 2/12/23, Jessica Clarke <jrtc27@freebsd.org> wrote: > >> >>> On 12 Feb 2023, at 21:13, Mateusz Guzik <mjg@FreeBSD.org> wrote: > >> >>>> > >> >>>> The branch main has been updated by mjg: > >> >>>> > >> >>>> URL: > >> >>>> > >> > https://cgit.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73= cdf181a0b > >> >>>> > >> >>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b > >> >>>> Author: Mateusz Guzik <mjg@FreeBSD.org> > >> >>>> AuthorDate: 2023-02-12 21:12:34 +0000 > >> >>>> Commit: Mateusz Guzik <mjg@FreeBSD.org> > >> >>>> CommitDate: 2023-02-12 21:12:34 +0000 > >> >>>> > >> >>>> zlib: silence K&R warns > >> >>>> > >> >>>> Sponsored by: Rubicon Communications, LLC ("Netgate") > >> >>>> --- > >> >>>> sys/conf/files | 18 +++++++++++------- > >> >>>> sys/modules/zlib/Makefile | 2 ++ > >> >>>> 2 files changed, 13 insertions(+), 7 deletions(-) > >> >>>> > >> >>>> diff --git a/sys/conf/files b/sys/conf/files > >> >>>> index 9171b434a7bf..53f90f7afc22 100644 > >> >>>> --- a/sys/conf/files > >> >>>> +++ b/sys/conf/files > >> >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c standard > >> >>>> libkern/strvalid.c standard > >> >>>> libkern/timingsafe_bcmp.c standard > >> >>>> contrib/zlib/adler32.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>> > >> >>> This doesn=E2=80=99t exist pre-Clang 15. > >> >>> > >> >> > >> >> this is main-only and it already has llvm15. the build requirement = is > >> >> top of the branch, so I don't see a problem. > >> >> > >> >> if you ran into trouble cross-compiling, you should probably update > >> >> that env instead of expecting working around the warn in the tree f= or > >> >> older compilers > >> > > >> > That is not our policy. Please fix this. > >> > > >> > >> Are you sure about that? I distinctly recall the supported path to get > >> top of the latest stable branch first, from there you should be able > >> to build the toolchain and the kernel. > >> > >> afaics the above change did not affect it > >> > >> If you insist, I can look for the exact paragraph in the docs. > >> > > > > The fix is trivial. > > > > https://reviews.freebsd.org/D38550 > > > > Please focus your efforts on commenting on the above and testing it out= . > > > > there is no warn with it > > but where is it stated that a compiler older than the newest in the > tree is supported for kernel builds? > As a project we've always benefitted from flexibility when it's trivial to be flexible. Warner > > > > > >> > Jess > >> > > >> >>> Jess > >> >>> > >> >>>> contrib/zlib/compress.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >>>> -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/crc32.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >>>> contrib/zlib/deflate.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >>>> -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/inffast.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/inflate.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/inftrees.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/trees.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >>>> contrib/zlib/uncompr.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >>>> -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/zutil.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >>>> diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefil= e > >> >>>> index 6391255e512b..178d3a3f7ab7 100644 > >> >>>> --- a/sys/modules/zlib/Makefile > >> >>>> +++ b/sys/modules/zlib/Makefile > >> >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTRICT_PROTOTYPES} = # > >> >>>> crc32.c:586 > >> >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # trees.c:232 > >> >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32 > >> >>>> > >> >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype > >> >>>> + > >> >>>> .include <bsd.kmod.mk> > >> >>> > >> >>> > >> >> > >> >> > >> >> -- > >> >> Mateusz Guzik <mjguzik gmail.com> > >> > > >> > > >> > >> > >> -- > >> Mateusz Guzik <mjguzik gmail.com> > >> > > > > > -- > Mateusz Guzik <mjguzik gmail.com> > --000000000000a947c605f487f118 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Sun, Feb 12, 2023 at 2:54 PM Mateu= sz Guzik <<a href=3D"mailto:mjguzik@gmail.com">mjguzik@gmail.com</a>>= wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px = 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2/12/= 23, Warner Losh <<a href=3D"mailto:imp@bsdimp.com" target=3D"_blank">imp= @bsdimp.com</a>> wrote:<br> > On Sun, Feb 12, 2023 at 2:40 PM Mateusz Guzik <<a href=3D"mailto:mj= guzik@gmail.com" target=3D"_blank">mjguzik@gmail.com</a>> wrote:<br> ><br> >> On 2/12/23, Jessica Clarke <<a href=3D"mailto:jrtc27@freebsd.or= g" target=3D"_blank">jrtc27@freebsd.org</a>> wrote:<br> >> > On 12 Feb 2023, at 21:23, Mateusz Guzik <<a href=3D"mailto= :mjguzik@gmail.com" target=3D"_blank">mjguzik@gmail.com</a>> wrote:<br> >> >><br> >> >> On 2/12/23, Jessica Clarke <<a href=3D"mailto:jrtc27@f= reebsd.org" target=3D"_blank">jrtc27@freebsd.org</a>> wrote:<br> >> >>> On 12 Feb 2023, at 21:13, Mateusz Guzik <mjg@FreeB= SD.org> wrote:<br> >> >>>><br> >> >>>> The branch main has been updated by mjg:<br> >> >>>><br> >> >>>> URL:<br> >> >>>><br> >> <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Deca005d8531fd= 153f46f941f3101e73cdf181a0b" rel=3D"noreferrer" target=3D"_blank">https://c= git.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73cdf181a0b</= a><br> >> >>>><br> >> >>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b<b= r> >> >>>> Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@= FreeBSD.org><br> >> >>>> AuthorDate: 2023-02-12 21:12:34 +0000<br> >> >>>> Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@= FreeBSD.org><br> >> >>>> CommitDate: 2023-02-12 21:12:34 +0000<br> >> >>>><br> >> >>>>=C2=A0 =C2=A0zlib: silence K&R warns<br> >> >>>><br> >> >>>>=C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Rubicon Com= munications, LLC ("Netgate")<br> >> >>>> ---<br> >> >>>> sys/conf/files=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 18 +++++++++++-------<br> >> >>>> sys/modules/zlib/Makefile |=C2=A0 2 ++<br> >> >>>> 2 files changed, 13 insertions(+), 7 deletions(-)= <br> >> >>>><br> >> >>>> diff --git a/sys/conf/files b/sys/conf/files<br> >> >>>> index 9171b434a7bf..53f90f7afc22 100644<br> >> >>>> --- a/sys/conf/files<br> >> >>>> +++ b/sys/conf/files<br> >> >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 standard<br> >> >>>> libkern/strvalid.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0standard<br> >> >>>> libkern/timingsafe_bcmp.c=C2=A0 standard<br> >> >>>> contrib/zlib/adler32.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib<br> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \<br> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"<br> >> >>><br> >> >>> This doesn=E2=80=99t exist pre-Clang 15.<br> >> >>><br> >> >><br> >> >> this is main-only and it already has llvm15. the build re= quirement is<br> >> >> top of the branch, so I don't see a problem.<br> >> >><br> >> >> if you ran into trouble cross-compiling, you should proba= bly update<br> >> >> that env instead of expecting working around the warn in = the tree for<br> >> >> older compilers<br> >> ><br> >> > That is not our policy. Please fix this.<br> >> ><br> >><br> >> Are you sure about that? I distinctly recall the supported path to= get<br> >> top of the latest stable branch first, from there you should be ab= le<br> >> to build the toolchain and the kernel.<br> >><br> >> afaics the above change did not affect it<br> >><br> >> If you insist, I can look for the exact paragraph in the docs.<br> >><br> ><br> > The fix is trivial.<br> ><br> > <a href=3D"https://reviews.freebsd.org/D38550" rel=3D"noreferrer" targ= et=3D"_blank">https://reviews.freebsd.org/D38550</a><br>; ><br> > Please focus your efforts on commenting on the above and testing it ou= t.<br> ><br> <br> there is no warn with it<br> <br> but where is it stated that a compiler older than the newest in the<br> tree is supported for kernel builds?<br></blockquote><div><br></div><div>As= a project we've always benefitted from flexibility when it's trivi= al to<br></div><div>be flexible.</div><div><br></div><div>Warner<br></div><= div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0= px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> ><br> ><br> >> > Jess<br> >> ><br> >> >>> Jess<br> >> >>><br> >> >>>> contrib/zlib/compress.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 optional crypto | geom_uzip | \<br> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \= <br> >> >>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual"<br> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual<br> >> >>>> -Wno-deprecated-non-prototype"<br> >> >>>> contrib/zlib/crc32.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \= <br> >> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_= WSTRICT_PROTOTYPES}"<br> >> >>>> contrib/zlib/deflate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \= <br> >> >>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual"<br> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual<br> >> >>>> -Wno-deprecated-non-prototype"<br> >> >>>> contrib/zlib/inffast.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib<br> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \<br> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"<br> >> >>>> contrib/zlib/inflate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib<br> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \<br> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"<br> >> >>>> contrib/zlib/inftrees.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 optional crypto | geom_uzip | \<br> >> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib<br> >> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \<br> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"<br> >> >>>> contrib/zlib/trees.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \= <br> >> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_= WSTRICT_PROTOTYPES}"<br> >> >>>> contrib/zlib/uncompr.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \= <br> >> >>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual"<br> >> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual<br> >> >>>> -Wno-deprecated-non-prototype"<br> >> >>>> contrib/zlib/zutil.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \<br> >> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \= <br> >> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_= WSTRICT_PROTOTYPES}"<br> >> >>>> diff --git a/sys/modules/zlib/Makefile b/sys/modu= les/zlib/Makefile<br> >> >>>> index 6391255e512b..178d3a3f7ab7 100644<br> >> >>>> --- a/sys/modules/zlib/Makefile<br> >> >>>> +++ b/sys/modules/zlib/Makefile<br> >> >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTR= ICT_PROTOTYPES} #<br> >> >>>> crc32.c:586<br> >> >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # = trees.c:232<br> >> >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # = zutil.c:27,32<br> >> >>>><br> >> >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype<br> >> >>>> +<br> >> >>>> .include <<a href=3D"http://bsd.kmod.mk" rel= =3D"noreferrer" target=3D"_blank">bsd.kmod.mk</a>><br> >> >>><br> >> >>><br> >> >><br> >> >><br> >> >> --<br> >> >> Mateusz Guzik <mjguzik <a href=3D"http://gmail.com" re= l=3D"noreferrer" target=3D"_blank">gmail.com</a>><br> >> ><br> >> ><br> >><br> >><br> >> --<br> >> Mateusz Guzik <mjguzik <a href=3D"http://gmail.com" rel=3D"nore= ferrer" target=3D"_blank">gmail.com</a>><br> >><br> ><br> <br> <br> -- <br> Mateusz Guzik <mjguzik <a href=3D"http://gmail.com" rel=3D"noreferrer" t= arget=3D"_blank">gmail.com</a>><br> </blockquote></div></div> --000000000000a947c605f487f118--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrHwRfuoCJrUAjQrvMyXduZ_qbWhBqz6cZeNi7KRpWjaA>