Date: Tue, 14 May 2013 21:20:01 GMT From: Kevin Zheng <kevinz5000@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/177857: [patch] Update x11/slim to 1.3.5 Message-ID: <201305142120.r4ELK1H1041583@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/177857; it has been noted by GNATS.
From: Kevin Zheng <kevinz5000@gmail.com>
To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/177857: [patch] Update x11/slim to 1.3.5
Date: Tue, 14 May 2013 16:13:32 -0500
On 05/14/2013 15:55, Raphael Kubo da Costa wrote:
>> LICENSE= GPLv2
>> +LICENSE_FILE= ${WRKSRC}/COPYING
>
> This shouldn't be needed. Standard licenses such as GPLv2 already have a
> copy in Templates/Licenses.
Ahh, thanks. I didn't realize that bsd.licenses.mk automatically sets
the LICENSE_FILE for standard license.
>> USES= cmake pkgconfig
>> +USE_RC_SUBR= slim
>> USE_XORG= ice sm x11 xau xdmcp xext xft xmu xorg-server xrender xt
>> -USE_RC_SUBR= slim
>> SUB_FILES= pkg-message
>
> Is there a reason for this change other than ordering the "USE_"
> variables alphabetically? Otherwise it just makes svn blaming more
> difficult.
No, I just felt the urge to have everything sorted. Feel free to undo
this change, everything works out either way.
>> . if ${PORT_OPTIONS:MPAM}
>> + @${MKDIR} ${PREFIX}/etc/pam.d
>
> You shouldn't need to do this, ${PREFIX}/etc/pam.d is part of the
> standard directories defined in Templates/BSD.local.dist.
Thanks, I wasn't sure. Now I know where to look in the future!
Thanks,
Kevin Zheng
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305142120.r4ELK1H1041583>