Date: Mon, 30 May 2005 13:41:31 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libstand Makefile Message-ID: <20050530104131.GB54585@ip.net.ua> In-Reply-To: <200505292105.j4TL5w32038570@repoman.freebsd.org> References: <200505292105.j4TL5w32038570@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--v9Ux+11Zm5mwPlX6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote:
> sobomax 2005-05-29 21:05:58 UTC
>=20
> FreeBSD src repository
>=20
> Modified files:
> lib/libstand Makefile=20
> Log:
> Add missed ${.CURDIR}/../../contrib/bzip2 into include search path, oth=
erwise
> old version of bzlib.h can be picked up from the /usr/include.
> =20
> Revision Changes Path
> 1.51 +1 -1 src/lib/libstand/Makefile
>=20
Changes like this, while harmless, unnecessarily pollute makefiles.
During buildworld we first install new headers then build new
libraries then the rest. When doing standalone compiles, the same
procedure should generally be followed. (Otherwise, you'd end up
changing every utility's makefile that uses libstand to add this
-I to CFLAGS.)
I have only problem with the above change: it has a wrong attribution
in the commit log. The correct commit log would be: "aid in lazy
standalone builds by always picking up a fresh copy of bzlib.h from
sources".
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--v9Ux+11Zm5mwPlX6
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)
iD8DBQFCmu3aqRfpzJluFF4RAnwXAJ43zyuFgq0JQpv1e68NpBV2Lb7zygCdGhuD
Q8qdjHf0f/Y7EztpFbYEXEY=
=gzRP
-----END PGP SIGNATURE-----
--v9Ux+11Zm5mwPlX6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050530104131.GB54585>