Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Dec 2001 15:11:39 -0800
From:      Peter Wemm <peter@wemm.org>
To:        Kirk McKusick <mckusick@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys buf.h 
Message-ID:  <20011214231139.BEF083808@overcee.netplex.com.au>
In-Reply-To: <200112141049.fBEAnFW14777@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Kirk McKusick wrote:
> mckusick    2001/12/14 02:49:15 PST
> 
>   Modified files:
>     sys/sys              buf.h 
>   Log:
>   Add disk I/O scheduling for positively niced processes.

Aside from the layering assumptions, there is an obvious gotcha:
                TAILQ_FOREACH(bn, &bioq->queue, bio_queue)
                        if (BIOTOBUF(bn)->b_vp != BIOTOBUF(bn)->b_vp)
                                     ^^                    ^^
                                break;

ie: LHS is the same as RHS

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011214231139.BEF083808>